Bug report

Required Info:

• Operating System:

  • Ubuntu 18.04

• Installation type:

  • Nightly build https://ci.ros2.org/view/packaging/job/packaging_linux/lastSuccessfulBuild/artifact/ws/ros2-package-linux-x86_64.tar.bz

Steps to reproduce issue

Execute:

 `rosdep install --from-paths ros2-linux/share --ignore-src --rosdistro dashing -y --skip-keys "console_bridge fastcdr fastrtps libopensplice67 libopensplice69 osrf_testing_tools_cpp poco_vendor rmw_connext_cpp rosidl_typesupport_connext_c rosidl_typesupport_connext_cpp rti-connext-dds-5.3.1 tinyxml_vendor tinyxml2_vendor urdfdom urdfdom_headers"
`

Expected behavior

Actual behavior

Step 17/21 : RUN rosdep install --from-paths $ROS2_WS/ros2-linux/share --ignore-src --rosdistro dashing -y --skip-keys "console_bridge fastcdr fastrtps libopensplice67 libopensplice69 osrf_testing_tools_cpp poco_vendor rmw_connext_cpp rosidl_typesupport_connext_c rosidl_typesupport_connext_cpp rti-connext-dds-5.3.1 tinyxml_vendor tinyxml2_vendor urdfdom urdfdom_headers"
 ---> Running in c1e24ef38e83
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
ament_cmake_ros: Cannot locate rosdep definition for [domain_coordinator]

See detailed https://travis-ci.org/RobotWebTools/rclnodejs/jobs/583689046#L13773

Additional information

This started to happen about one week ago, I haven't changed the configuration of the Docker.

What are the chances ament_add_ros_isolated_gtest() can be backported to dashing?

It appears that the relevant commit only adds files, so I'm guessing that the risk of a regression would be rather low.

Follow up of #3.

At the moment the function get_coordinated_domain_id returns an object wrapping a socket and mentions in the docblock that it relies on the garbage collector to destroy the socket when no references are hold anymore. Since in Python the garbage collector might run anytime (or never) this isn't a viable API.

During the tests even a warning is printed that the sockets are never being closed: https://ci.ros2.org/view/All/job/test_ci_windows/196/pytest-warnings/

@pbaughman Since you create the original pull request implementing this API can you please look into this and revise the API in a follow up PR to make it explicit and deterministic?