This issue tracks the progression of the package console_bridge_vendor that have been deemed necessary for Quality Level 1. It follows the outline described in REP 2004.

• Version Policy
  • semver according to the recommendation for ROS Core packages in the ROS 2 Developer Guide.
• Version >= 1.0.0
• Change Control Process
  • Recommended guidelines for ROS Core packages in the ROS 2 Developer Guide
• API and ABI stability within a ROS distribution (libconsole-bridge-dev use limited to stable releases)
• Vulnerability Disclosure Policy

Documentation

• Per-feature documentation.
  • (This package does not define its own features)
• Per-item documentation in public API.
  • (This package does not define its own API)
• Declared set of licenses
• Copyright statement in each source file
  • Checked with ament_copyright
• Quality Declaration document

Testing:

• System tests, which cover "features"
  • (Does not apply for vendored packages)
• Tests covering public API
  • (Does not apply for vendored packages)
• Code Coverage > 95%:
  • (Does not apply for vendored packages)
• Performance tests.
  • (Does not apply for vendored packages)
• Linters and Static Analysis:
  • • Must have a code style and enforce it.
  • • Must use static analysis tools where applicable:
      -- Linters applied to package.xml and CmakeLists.txt files. See Linters ROS 2 Developer Guide

Dependencies:

• Runtime "ROS" dependencies are level 1
  • None
• non-ROS dependencies are equivalent level 1
  • libconsole-bridge-dev (QL 2)

Platform Support

• Supports all tier 1 platforms as described in REP-2000

I recently ran into https://github.com/ros2/ros2/issues/743 which essentially led to ros/console_bridge#63

This is more like a question, wondering why we are settled on v.0.4.1 instead of master (v.0.4.3).

We're currently running into linker conflicts when compiling MoveIt 2 for Foxy with clang.

• Travis: https://travis-ci.com/github/ros-planning/moveit2/jobs/372952760#L578
• MoveIt Issue: ros-planning/moveit2#242
• Original comment: ros-planning/geometric_shapes#153 (comment)

/usr/bin/ld: warning: libconsole_bridge.so.0.4, needed by /opt/ros/foxy/lib/x86_64-linux-gnu/liburdfdom_sensor.so.1.0, may conflict with libconsole_bridge.so.1.0

MoveIt is depending on console_bridge through geometric_shapes and srdfdom which recursively depends on urdfdom. The problem is that the urdfdom debian (and many other ROS packages) depends on libconsole_bridge.so.0.4 while console_bridge_vendor already provides libconsole_bridge.so.1.0 resulting in the linker conflict shown above. My understanding was that this is exactly the issue that the vendor package should solve. However, if using the vendor package or not doesn't seem to make any difference when compiling srdfdom and MoveIt 2 (see https://github.com/ros-planning/srdfdom/pull/61/files for srdfdom tested with and without vendor package). The linker conflict doesn't occur when compiling the conflicting packages (here urdfdom) from source. To me it seems like the only option would be to have urdfdom released using the latest console_bridge version and from then on keeping all downstream dependencies synced.

Is this by any chance just a bug in the vendor package or a misconfiguration in one of the related packages? Any help would be greatly appreciated.

@clalancette tagging you as you've been involved in this package and in the original discussion.

The minimum required cmake version in the CMakeLists.txt file is 3.5, but here

target_link_directories is used, which was added in cmake 3.13. This makes this package fail to build on Ubuntu Bionic.

Hi, I am trying to build this package inside docker. I am using this docker file. The docker is using Ubuntu 20.04 as base OS. In that docker file, at line no 124, while executing colcon build command, it is giving following error. What can be the reason behind this?

CMake Warning (dev) at /usr/share/cmake-3.24/Modules/ExternalProject.cmake:3071 (message):
  The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
  not set.  The policy's OLD behavior will be used.  When using a URL
  download, the timestamps of extracted files should preferably be that of
  the time of extraction, otherwise code that depends on the extracted
  contents might not be rebuilt if the URL changes.  The OLD behavior
  preserves the timestamps from the archive instead, but this is usually not
  what you want.  Update your project to the NEW behavior or specify the
  DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
  robustness issue.
Call Stack (most recent call first):
  /usr/share/cmake-3.24/Modules/ExternalProject.cmake:4167 (_ep_add_download_command)
  CMakeLists.txt:68 (externalproject_add)
  CMakeLists.txt:97 (build_console_bridge)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at /opt/ros/humble/install/share/performance_test_fixture/cmake/ament_cmake_export_targets-extras.cmake:18 (message):

  Failed to find exported target names in
  '/opt/ros/humble/install/share/performance_test_fixture/cmake/performance_test_fixtureExport.cmake'

Call Stack (most recent call first):
  /opt/ros/humble/install/share/performance_test_fixture/cmake/performance_test_fixtureConfig.cmake:41 (include)
  /opt/ros/humble/install/share/ament_lint_auto/cmake/ament_lint_auto_find_test_dependencies.cmake:36 (find_package)
  CMakeLists.txt:106 (ament_lint_auto_find_test_dependencies)

When compiling console_bridge with clang, I get the following warnings:

In file included from /vol/sandbox/ros2/src/srdfdom/src/model.cpp:38:
/opt/ros/dashing/include/console_bridge/console.h:67:90: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_ERROR, fmt, ##__VA_ARGS__)

As far as I can see, these code lines should read (replacing ##__VA_ARGS__ with #__VA_ARGS__):

#define CONSOLE_BRIDGE_logError(fmt, ...)  \
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_ERROR, fmt, #__VA_ARGS__)

#define CONSOLE_BRIDGE_logWarn(fmt, ...)   \
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_WARN,  fmt, #__VA_ARGS__)

#define CONSOLE_BRIDGE_logInform(fmt, ...) \
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_INFO,  fmt, #__VA_ARGS__)

#define CONSOLE_BRIDGE_logDebug(fmt, ...)  \
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_DEBUG, fmt, #__VA_ARGS__)

As I'm not sure which is the actual source repository, I'm filing an issue here instead of a PR.