skills / test-with-actions Goto Github PK
View Code? Open in Web Editor NEWCreate workflows that enable you to use Continuous Integration (CI) for your projects.
License: MIT License
Create workflows that enable you to use Continuous Integration (CI) for your projects.
License: MIT License
Describe the bug
When following the current instruction of Step 4, learners are later forced to do
Merge without waiting for requirements to be met (bypass branch protections)
in Step 5 to proceed
and this does not meet with the purpose of setting up branch protection (somewhat contradicting)
To Reproduce
Steps to reproduce the behavior:
continuous-integration
Require a pull request before merging
as suggested in #8Require approvals
and set required number of approvals to 1 (Screenshot 1)Merge without waiting for requirements to be met (bypass branch protections)
to proceed (Screenshot 2)Expected behavior
learners must be instructed to uncheck Require approvals
in Step 4.4
Screenshots
Device information
Additional context
As per this blog post, version 3 of the upload-artifact action will be deprecated on November 30th 2024. A change is needed to update the action version used from 3 to 4 to avoid being affected by the deprecation.
Update to use actions/upload-artifact@v4 instead of actions/upload-artifact@v3 in 3-upload-test-reports.md
The following Annotations currently appear in the workflow summary when using upload-artifact@v3.
ToDo of PR #53
Make a script to merge changes from origin/main
into ci
and run it before updating to Step 5 in the Step 4 workflow.
An extract from the current Step 5 markdown
1. Go to the **Pull requests** tab.
1. Resolve any merge conflicts. <!-- TODO: figure out a better way to deal with the merge conflicts. -->
1. Click **Merge pull request**.
The linting step in the learners' workflow raised unexpected errors.
ci.yml
. (Step was updated to 2 on the push to the ci
branch.)ci.yml
workflow.)Run npm install remark-cli remark-preset-lint-consistent npm install remark-cli remark-preset-lint-consistent npx remark . --use remark-preset-lint-consistent --frail shell: /usr/bin/bash -e {0} added 320 packages in 6s 136 packages are looking for funding run `npm fund` for details .github/steps/0-welcome.md: no issues found .github/steps/1-add-a-test-workflow.md 24:32-24:38 warning Emphasis should use `_` as a marker emphasis-marker remark-lint .github/steps/2-fix-the-test.md: no issues found .github/steps/3-upload-test-reports.md: no issues found .github/steps/4-add-branch-protections.md: no issues found .github/steps/5-merge-your-pull-request.md 18:5 warning Don’t use mixed indentation for children, remove 1 space list-item-content-indent remark-lint .github/steps/X-finish.md: no issues found README.md: no issues found resume.md 9:18-9:23 warning Emphasis should use `_` as a marker emphasis-marker remark-lint ⚠ 3 warnings Error: Process completed with exit code 1.
Made in #51 😬
On step 2 of the process, I cannot get the test to pass. The error I get is:
npm ERR! 404 Not Found - GET https://registry.npmjs.org/remark-present-link-consistent - Not found
I dont know GitHub actions (i was trying to learn) so I cannot tell you how to fix this, but...
And btw, the GitHub UI has changed significantly, the names of the buttons, the screenshots.... that doesnt help.
To help clarify and simplify the intention of the course, and use more beginner friendly terminology, proposing we rename this course "Test with Actions".
Describe the bug
Step 2 won't open in the 'main' branch.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Step 2 opens both in the main
and ci
branch.
Screenshots
If applicable, add screenshots to help explain your problem.
Device information
Additional context
Add any other context about the problem here.
According to https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md there's a number of YAML tools installed on the Actions runners by default. We could investigate if these tools could offer more checks for learners.
Step "Run markdown lint" ends with en error and the README.md
isn't updated
Open a new browser tab, and work on the steps in your second tab while you read the instructions in this tab
Go to the Actions tab.
Click New workflow.
Search for "Simple workflow" and click Configure.
Name your workflow ci.yml
.
Update the workflow to remove all steps other than the "checkout" step.
Add the following step to your workflow:
- name: Run markdown lint
run: |
npm install remark-cli remark-preset-lint-consistent
npx remark . --use remark-preset-lint-consistent --frail
Even after the code is indented properly in
ci.yml
, you will see a build error in GitHub Actions. We'll fix this in the next step.
Click Start commit, and choose to make a new branch named ci
.
Click Propose a new file.
Click Create pull request.
Wait about 20 seconds then refresh this page (the one you're following instructions from). GitHub Actions will automatically update to the next step.
Describe the bug
Step 1.3 Search for "Simple workflow" isn't visible in the Actions tab until clicking New Workflow. This wasn't obvious (at least to me) and isn't mentioned in the write up.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Step 3 could read : Click new workflow and then search for "Simple workflow"
Package name remark should be remark-cli instead
The student/learner will correct the "npx" to "npm" and the correct package name to invoke here is "remark-cli"
As far as I can tell, the documentation for the test-with-actions lesson template is very out of date.
The steps from 8 - 10 cannot be followed. The language doesn't match what is actually seen on the screen. Not only that but no prompt is given to create a new branch or Create a pull request
.
Perhaps I'm just misunderstanding the instructions but regardless, despite my best faith attempt at following the lesson, I cannot seem to make sense of the instructions as listed below.
The branch_protection_rule
trigger in 4-add-branch-protections.yml has an unexpected value branches
(Ln 14).
Add any other context about the problem here.
It is expected that in the first step, we will have an error generated to resolve, but mine does not generate any error. I appreciate any help!
ci.yml
.- name: Run markdown lint
run: |
npm install remark-cli remark-preset-lint-consistent
npx remark . --use remark-preset-lint-consistent --frail
No error when seeing the Actions tab.
same error
Originally posted by @xuhongl in #17 (comment)
A clear and concise description of what the problem is, and what you solution you want.
What changes this feature would introduce. Any risks these changes involve. Any alternative solutions or features you've considered.
Add any other context or screenshots about the feature request here.
actions/upload-artifact does not know what artifact to upload in Step 3
Step 3: Upload test reports
No files were found with the provided path: public/. No artifacts will be uploaded
This might be an error on my end, but the guide seems to be missing a step about how to upload the output of the markdown linter, as if actions/upload-artifact
will automagically detect output from the previous step (which does not seem to be the case)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.