Git Product home page Git Product logo

Comments (5)

sinsukehlab avatar sinsukehlab commented on August 22, 2024 2

This error is intentional.

Even after the code is indented properly in ci.yml, you will see a build error in GitHub Actions. We'll fix this in the next step.

from test-with-actions.

hectorsector avatar hectorsector commented on August 22, 2024 1

@sinsukehlab is right, but I agree that the instructions expect the learner to do a lot of heavy lifting with reading so I'll leave this open but it's feedback about the course structure mostly.

from test-with-actions.

Gabor12321 avatar Gabor12321 commented on August 22, 2024

the task: "Update the code in the ci branch to get the test to pass." Clue: on line 18 there is a file. the issue has something to do with markdown syntax. i personally asked chat gpt, and thats how i reached to the solution after a long time.. good luck!

from test-with-actions.

javeedambu avatar javeedambu commented on August 22, 2024

The following line is causing the warning and error

npx remark . --use remark-preset-lint-consistent --frail

The "." is asking to check all files for markdown syntax and its warning that "resume.md" is not following the syntax.

You can use "" or "*" to markdown as italics font.
However when you use "consisent" as in the code above, then you should only use either "
" or "" throughout the file.
"resume.md" started using "_" and then later it also used "
", hence the warning.
(ref:https://www.npmjs.com/package/remark-lint-emphasis-marker/v/3.1.0)

The "--frail" will exits as failed when there is a warnings.
(ref: Search for "--frail" in the URL:https://github.com/remarkjs/remark-lint)

In short if you where to replace *Git* with _Git_ in the "resume.md" then you will not have any errors.

But then we don't get to do the LAB as per the instructions provided.

Also the error Screenshots mentioned in Step2 - "Review required" and "Merging is blocked" never occurs, as there were no Branch rules already to cause this error.

If at the beginning of the Step1, we add a step to create a branch rule requiring one reviewer approval then we get this error when attempting to perform the pull request after creating the ci.yml.

from test-with-actions.

cmwilson21 avatar cmwilson21 commented on August 22, 2024

Linking issue #48

@skills/technical-reviewers Would ya'll mind taking a look at this one? 👀 👍

from test-with-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.