Describe the bug
Step 1.3 Search for "Simple workflow" isn't visible in the Actions tab until clicking New Workflow. This wasn't obvious (at least to me) and isn't mentioned in the write up.

To Reproduce
Steps to reproduce the behavior:

1. Try to follow the steps described in Step 1

Expected behavior
Step 3 could read : Click new workflow and then search for "Simple workflow"

Describe the bug
There is an error when running npm install remark-cli remark-preset-lint-consistent

Summary

The file "/.github/workflows/4-add-branch-protections.yml" is not working, the step switching part is commented

How to reproduce

Just create a branch protection and nothing will happen to switching automatically to the next step

Summary

The linting step in the learners' workflow raised unexpected errors.

How to reproduce

1. Start the course.
2. Follow Step 1.
3. Create ci.yml. (Step was updated to 2 on the push to the ci branch.)
4. Create pull request. (This triggered the ci.yml workflow.)
5. See error.

   Run npm install remark-cli remark-preset-lint-consistent
     npm install remark-cli remark-preset-lint-consistent
     npx remark . --use remark-preset-lint-consistent --frail
     shell: /usr/bin/bash -e {0}
   
   added 320 packages in 6s
   
   136 packages are looking for funding
     run `npm fund` for details
   .github/steps/0-welcome.md: no issues found
   .github/steps/1-add-a-test-workflow.md
   24:32-24:38 warning Emphasis should use `_` as a marker                      emphasis-marker          remark-lint
   
   .github/steps/2-fix-the-test.md: no issues found
   .github/steps/3-upload-test-reports.md: no issues found
   .github/steps/4-add-branch-protections.md: no issues found
   .github/steps/5-merge-your-pull-request.md
   18:5        warning Don’t use mixed indentation for children, remove 1 space list-item-content-indent remark-lint
   
   .github/steps/X-finish.md: no issues found
   README.md: no issues found
   resume.md
   9:18-9:23   warning Emphasis should use `_` as a marker                      emphasis-marker          remark-lint
   
   ⚠ 3 warnings
   Error: Process completed with exit code 1.
   

Additional context

Made in #51 😬

Summary

As per this blog post, version 3 of the upload-artifact action will be deprecated on November 30th 2024. A change is needed to update the action version used from 3 to 4 to avoid being affected by the deprecation.

Changes

Update to use actions/upload-artifact@v4 instead of actions/upload-artifact@v3 in 3-upload-test-reports.md

Additional context

The following Annotations currently appear in the workflow summary when using upload-artifact@v3.

Summary

ToDo of PR #53

Changes

Make a script to merge changes from origin/main into ci and run it before updating to Step 5 in the Step 4 workflow.

Additional context

An extract from the current Step 5 markdown

1. Go to the **Pull requests** tab.
1. Resolve any merge conflicts. <!-- TODO: figure out a better way to deal with the merge conflicts. -->
1. Click **Merge pull request**.

According to https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md there's a number of YAML tools installed on the Actions runners by default. We could investigate if these tools could offer more checks for learners.

Summary

The branch_protection_rule trigger in 4-add-branch-protections.yml has an unexpected value branches (Ln 14).

How to reproduce

1. Open this repository on VS Code.
2. Enable the GitHub Actions extension.
3. Open the PROBLEMS panel.
4. See error.

Additional context

Add any other context about the problem here.

Summary

actions/upload-artifact does not know what artifact to upload in Step 3

How to reproduce

1. Edit ci.yml as explained in Step 3: Upload test reports
2. Run action
3. Get Warning No files were found with the provided path: public/. No artifacts will be uploaded
   

Additional context

This might be an error on my end, but the guide seems to be missing a step about how to upload the output of the markdown linter, as if actions/upload-artifact will automagically detect output from the previous step (which does not seem to be the case)

Describe the bug
Step 2 won't open in the 'main' branch.

To Reproduce
Steps to reproduce the behavior:

1. Go to Step1
2. Complete the Activity
3. Refresh after ~20 seconds
4. See error

Expected behavior
Step 2 opens both in the main and ci branch.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
Completing "Step 2: Fix the test" doesn't result in the Step 3 being opened in the README.

This is because the 2-fix-the-test.yml workflow is looking for push on README.md however the test is failing because of a lint error in resume.md:

          same error

Originally posted by @xuhongl in #17 (comment)

Summary

I dont know GitHub actions (i was trying to learn) so I cannot tell you how to fix this, but...

How to reproduce

1. I finished step 1 and added the CI file to the branch.
2. Flow took me to step 2 "fix the test", but there is simply not enough information to the uninitiated to know what test its been talked about.
3. There are simply not enough steps detail, i got lost, completely, gave up.

Additional context

And btw, the GitHub UI has changed significantly, the names of the buttons, the screenshots.... that doesnt help.

Summary

A clear and concise description of what the problem is, and what you solution you want.

Changes

What changes this feature would introduce. Any risks these changes involve. Any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

1. When I add a simple workflow, and add the code from step 1, my workflow never fails.
2. It shows all checks are passed, installs npm package and all. It never runs any tests.
3. I am not able to move to the next step.

As far as I can tell, the documentation for the test-with-actions lesson template is very out of date.

The steps from 8 - 10 cannot be followed. The language doesn't match what is actually seen on the screen. Not only that but no prompt is given to create a new branch or Create a pull request.

Perhaps I'm just misunderstanding the instructions but regardless, despite my best faith attempt at following the lesson, I cannot seem to make sense of the instructions as listed below.

8. Click Start commit, and choose to make a new branch named ci.
9. Click Propose a new file.
10. Click Create pull request.

Summary

Package name remark should be remark-cli instead

How to reproduce

1. Go to 'https://github.com/skills/test-with-actions/blob/main/.github/steps/1-add-a-test-workflow.md'
2. Click on '1-add-a-test-workflow.md'
3. Scroll down to 'Activity: Add a test workflow'
4. Go to "Step 7. Add the following step at the end of your workflow:"
5. In the part that says "npx remark" it should be "npx remark-cli" instead.

Additional context

The student/learner will correct the "npx" to "npm" and the correct package name to invoke here is "remark-cli"

Describe the bug
When following the current instruction of Step 4, learners are later forced to do
Merge without waiting for requirements to be met (bypass branch protections) in Step 5 to proceed
and this does not meet with the purpose of setting up branch protection (somewhat contradicting)

To Reproduce
Steps to reproduce the behavior:

1. start the course of continuous-integration
2. complete until Step 3
3. in Step 4.4, check Require a pull request before merging as suggested in #8
4. doing so will automatically insert check into Require approvals and set required number of approvals to 1 (Screenshot 1)
5. since the learners are likely to have only him/herself in the learning repository, he/she cannot approve the pull request on the own in Step 5 and end up doing Merge without waiting for requirements to be met (bypass branch protections) to proceed (Screenshot 2)
6. this does not make sense since learners are forced to bypass branch protection they just configured

Expected behavior
learners must be instructed to uncheck Require approvals in Step 4.4

Screenshots

• Screenshot 1
  
• Screenshot 2
  

Device information

• in any environment

Additional context

• None

Summary

Step "Run markdown lint" ends with en error and the README.md isn't updated

How to reproduce

1. Open a new browser tab, and work on the steps in your second tab while you read the instructions in this tab

2. Go to the Actions tab.

3. Click New workflow.

4. Search for "Simple workflow" and click Configure.

5. Name your workflow ci.yml.

6. Update the workflow to remove all steps other than the "checkout" step.

7. Add the following step to your workflow:

   - name: Run markdown lint
     run: |
       npm install remark-cli remark-preset-lint-consistent
       npx remark . --use remark-preset-lint-consistent --frail

   Even after the code is indented properly in ci.yml, you will see a build error in GitHub Actions. We'll fix this in the next step.

8. Click Start commit, and choose to make a new branch named ci.

9. Click Propose a new file.

10. Click Create pull request.

11. Wait about 20 seconds then refresh this page (the one you're following instructions from). GitHub Actions will automatically update to the next step.

To help clarify and simplify the intention of the course, and use more beginner friendly terminology, proposing we rename this course "Test with Actions".

Summary

It is expected that in the first step, we will have an error generated to resolve, but mine does not generate any error. I appreciate any help!

How to reproduce

1. Go to the Actions tab.
2. Click New workflow.
3. Search for "Simple workflow" and click Configure.
4. Name your workflow ci.yml.
5. Update the workflow by deleting the last two steps.
6. Add the following step at the end of your workflow:

   - name: Run markdown lint
     run: |
       npm install remark-cli remark-preset-lint-consistent
       npx remark . --use remark-preset-lint-consistent --frail

My ci.yml:

No error when seeing the Actions tab.

Is your feature request related to a problem? Please describe.
hard to understand what is meant in the image below

On step 2 of the process, I cannot get the test to pass. The error I get is:

npm ERR! 404 Not Found - GET https://registry.npmjs.org/remark-present-link-consistent - Not found

Summary

Workflow .github/workflows/4-add-branch-protections.yml is not working.

How to reproduce

1. Create or edit branch protection setting
2. Merge changes from origin main into ci step failure

Additional context

It's seem .github/script/merge-branch.sh has not executable permission.