Git Product home page Git Product logo

Comments (11)

ProDataMan avatar ProDataMan commented on July 21, 2024 8

yes what does that mean? in the instructions it says to update the code in the ci branch. what code? what are you supposed to update? you need to look for something like underscore look for it where? look for that text literally? The only place I was able to find that text was in the readme.md file that I was reading it in.

from test-with-actions.

thongonary avatar thongonary commented on July 21, 2024 2

The instruction should have explained what the installed packages do
https://unifiedjs.com/explore/package/remark-lint-emphasis-marker/

This package is a unified (remark) plugin, specifically a remark-lint rule. Lint rules check markdown code style.
You can use this package to check that emphasis markers are consistent.

This would make it way less confusing.

from test-with-actions.

leonfeng avatar leonfeng commented on July 21, 2024 2

If you're not seeing the ❌ Some checks didn't pass message, chances are you left extra lines in the workflow file.

Go back to Step 1, Task 6. Open ci.yml and delete everything from line 28 to EOF. Now the last non-blank line in your file should read - uses: actions/checkout@v3. Continue with Task 7 and add the markdown lint step.

If that doesn't help, try deleting the repo and starting over.

from test-with-actions.

AndylLow avatar AndylLow commented on July 21, 2024 1

For anyone stuck at this step:
Go to line 115 in readme and change both "*" into "_".

from test-with-actions.

ndagisusan avatar ndagisusan commented on July 21, 2024 1

Thank you @leonfeng and @AndylLow for your solutions.
This has finally worked for me 🙏

from test-with-actions.

sinsukehlab avatar sinsukehlab commented on July 21, 2024

Check the error in the ci.yml build and you will find a helpful warning message.

from test-with-actions.

sinsukehlab avatar sinsukehlab commented on July 21, 2024

Step 0 contains a link to the remark-lint GitHub repository, but is commented out by 0-start.yml.

from test-with-actions.

MathElderGod avatar MathElderGod commented on July 21, 2024

look at the read me, line 115. The libraries cause rules to be implemented based on emphasis...I was stuck on this for about 1:30 hour

from test-with-actions.

ted-repo avatar ted-repo commented on July 21, 2024

Still trying to figure out the solution on how to complete this activity Fix the test

Anyone with more direct guidance? thanks,

from test-with-actions.

sinsukehlab avatar sinsukehlab commented on July 21, 2024

Go to the Actions tab and check the error.
Follow the warning message.

found 0 vulnerabilities
README.md
  115:1-115:63  warning  Emphasis should use `_` as a marker  emphasis-marker  remark-lint

⚠ 1 warning
Error: Process completed with exit code 1.

from test-with-actions.

k-byun avatar k-byun commented on July 21, 2024

still stuck. Action workflow screenshot shown just before line 115 doesn't look like what I am seeing on my workflow (ie, I don't see "Review required", the first big ❌)

from test-with-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.