Git Product home page Git Product logo

Comments (2)

ayumi-signal avatar ayumi-signal commented on June 14, 2024

@crashkopf Hi, it seems like UNC paths are used to access network paths, and in the discussion in #5427 there was a decision to consider Signal network path file access a feature request, because it's not by design that Signal works across network paths for security reasons.

This seems to be very similar to #5427 and I'd ask that you post in the Community Forum Desktop Feature Requests (https://community.signalusers.org/c/feature-requests/desktop-feature-requests/20) to show support for the feature before we implement it.

from signal-desktop.

crashkopf avatar crashkopf commented on June 14, 2024

Regardless of whether the maintainers intend to support user profiles stored on networked drives (which rightfully should be the choice of the user or system administrator), the following salient points should be considered:

  • The path-handling code for attachments is not working as intended. In other parts of the app, userDataPath isn't being being mangled, so there's some inconsistency. File paths should be handled correctly and consistently throughout the app.
  • The app is using %APPDATA%/Signal as it's path to store user data. If that's the design choice then you have to respect that %APPDATA% can be any valid directory path. See https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats. In fact, UNC paths are part of the protocol filter tests, implying they're already intentionally supported.

from signal-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.