Thanks for you job, very good!

I hope to see more features!

As mentioned here, I was still in the process of making tests for the word-diff feature #69.

I can still create them but I didn't get that far if you want to create them yourself :)

I usually find it very useful to see the --word-diff of a commit instead of the normal diff.

I have a working (albeit hacked together) version working that passes the default --word-diff=plain to the git arguments in s:blame__reveal_diff and added some additional syntax stuff to highlight the word-diff. One issue that popped up is that lines can become quite long as seen in the screenshot.

For starters, I can clean everything up and submit a pull request if you agree this would be a useful feature?

When opening the floating window with an existing split window the cursor is jumping to the split window:

Repro

1. git init .
2. echo aaa > foo.txt
3. git add foo.txt && git commit -m 'init'
4. vim foo.txt
5. :GitMessenger
6. :GitMessenger
7. Type d

Expected

Show diff of initial commit of file foo.txt

Actual

Error as follows:

git-messenger: fatal: bad revision 'xxxxxxxx^..xxxxxxxx' : `git --no-pager diff xxxxxxxx^..xxxxxxxx -- nvimrc` exited with non-zero status 128

where xxxxxxxx is a commit hash

Investigation

This issue is caused because git-messenger.vim obtains diff of specific commit by git diff {hash}^..{hash}. For initial commit, {hash}^ is invalid so the commit fails.

If a long text line was wrapped, the position of floating window is not correct.

For example,

should be corrected to

Related: #31

If the commit message starts with square brackets [] opening and closing the diffs duplicate the text

Commit example:

Dummy commit

[Test] git messenger commit test

Steps:

• Create a new commit with the commit example
• Execute :GitMessenger
• Jump to gitmessenger window and reveal diff with "d" or "D"

If I press d to see diff, there's a pause as it decides whether I meant "show diff" or "delete". Adding <nowait> to line 177 of autoload/gitmessenger/popup.vim fixes that. It may be worth having behind an option in case it conflicts with something.

Is possible to toggle diffs by pressing d or D twice? i.e the first time actually reveal the diff hunks and the second time d or D is press hide them. Thanks!

Repro

1. Clone https://github.com/rhysd/git-messenger.vim.git
2. cd /path/to/git-messenger
3. Open .github/workflows/ci.yaml
4. Run :GitMessenger

Expected behavior

The command runs successfully

Actual behavior

git-messenger: Directory '/Users/rhysd/.vim/bundle/git-messenger.vim/.github/workflows' is not inside a Git repository

Environment

• git-messenger: 74b767a
• Vim: 8.2.2164

I have remapped d to scroll down the half-page in my workflow, but git-messenger.vim can't unmap d inside popup.

filetype event didn't work because it was triggered before mapping key inside the popup window.

Pressing any of the default mapping keys just do the default neovim action. (e.g: o sets the insert mode and add a newline)

Any idea?

When a popup window is already open, it moves cursor into the window.

Repro

1. git clone https://github.com/rhysd/git-messenger.vim.git && cd git-messenger.vim
2. Open README.md
3. Move cursor to line starting with - (list item). At this time it's L15 for instance
4. :GitMessenger twice to enter the popup
5. r to reveal word diff

Expected behavior

Only removed parts are highlighted as 'removed'

Actual behavior

The line starting with - is also highlighted as 'removed'

Environment

• git-messenger.vim: be97d5e
• Vim: 8.2.2164

I think readme & help file should be modified with following part.

At first, readme describes as follows and that is true.

If you don't like the default mapping, set g:git_messenger_no_default_mappings to v:true in your .vimrc or init.vim and map the mapping to your favorite key sequence.

but below lines seems to explaining opposite thing.

g:git_messenger_no_default_mappings (Default: v:true)

When this value is set to v:false, it does not define any key mappings. mappings are >still defined since they don't make any conflict with existing mappings.

It should be

• (Default: v:false) = given default is not v:true but v:false.
• When this value is set to v:true, it does not .... = with v:true, there would be no default key mapping.

Thanks.

File paths that include a space fail to resolve in gitmessenger#git#root_dir() resulting in the error:

git-messenger: Directory '/my git root with space' is not inside a Git repository

Behavior of this command is depending on the situation. You can do every operations only with this mapping.

• Normally, it opens a popup window with the last commit message
• When a popup window is already open, it moves cursor into the window
• When a cursor is within a popup window, it closes the window

<leader>gm open the popup properly, I can see all the info. But the cursor is not moved inside so I can't use any of the other mappings to go back/forward in history etc…

As you can see in the image, o creates a new line & D deletes the rest of the line.

Repro

git init .
echo foo > a.txt
git add a.txt
git commit -m init
git checkout -b other
git checkout -
git worktree add work other

Then open work/a.txt and run :GitMessenger

Expected behavior

Show the 'init' commit

Actual behavior

Cause an error as follows:

git-messenger: fatal: no such path 'work/a.txt' in HEAD: `git --no-pager blame /Users/rhysd/Tmp/foo/work/a.txt -L 1,+1 --porcelain` exited with non-zero status 128

Note: This is not related to #37 but I found this bug while debugging the issue.

git-messenger.vim is a Vim/Neovim plugin to reveal the hidden message from Git under the cursor quickly. It shows the history of commits under the cursor in popup window.

I know that this plugin is developed to display the commited messenger and blame.
Could it support diff for unstaged/uncommited content? (like what git-p does)

Using Vim 8.1, when git-messenger opens the preview-window on a file containing open folds, they are all closed as if I had just opened the file. I have to manually open them again to restore the view as it was before calling git-messenger.

However when I switch to the preview-window or close it using the same mapping, my folds are kept intact.

git-messenger: Directory '/home/fuzzy/repos/mitmproxy/examples/addons' is not inside a Git repository

Can it try to search it in parent folders too instead of just $PWD ?

Similar to what @voldikss pointed out in #16, when I use :GitMessenger or <Leader>gm, the preview opens, then immediately closes. Made a video:

Happy to provide any other information!

Hi. Great plugin but I'm having an issue with whitespace and I'd like to add a flag to diff (-w) to fix it. How would I go about doing that?

Awesome plugin! I found one minor nit. Consider the following minimal init.vim:

set nocompatible

let $DOTVIM = expand('$HOME/.config/nvim')

set runtimepath+=$DOTVIM/bundle/repos/github.com/rhysd/git-messenger.vim

filetype plugin indent on
let g:mapleader = ','
nmap <silent> <Leader>gm <Plug>(git-messenger)

Now as in the GIF:

1. run ,gm twice from a right vertical split window
2. Press D in the floating window to get a diff
3. Press q to exit the floating window
4. Now the cursor is on the left vertical split
   I expect the cursor position to be preserverd.

Bonus: is it possible to render diffs always below the cursor? Currently when I press D inside the floating window then the floating window generally moves to the upper west corner of the screen.

vimproc 有効時にもステータス参照に v:shell_status を見にいってしまっているため、シェルコマンドのステータスを正常にハンドリングできていません。
vimproc利用時には vimproc#get_last_status() でステータスを取得できます。

修正してみましたが、Pull-req を送る程でもないので、Issueにしておきます。

Hi! I've been using this plugin for a few months now, and today I noticed that it does not detect a symlinked folder that is inside a git directory. That is, if the original directory/file is in a git repo, and I am accessing the symlink through vim, it does not detect the repo. WOuld it be possible to add this enhancement?

Hi, @rhysd :
I am debugging a vim plugin using BufEnter autocmd on nvim. I found that when I call :GitMessenger, a BufEnter autocmd is triggered. But BufEnter won't be triggered again when float window disappear (git_messenger_close_on_cursor_moved is true).
My plugin depends BufEnter to do some detect. When it enter to git-messenger buffer, function is closed, and there is no condition to make me open function again when back to normal buffer.
I am not familiar with vimscript, so could you help to answer my question?

1. Is this the vim/nvim behavior which plugins can not do something to change it ?
2. Does git-messenger depends on this autocmd? Could git-messenger do something to make no BufEnter on popup window show or BufEnter again when popup window close? (Because I think it may be a more compatible behavior to have pairing autocmd.)
   This may not an issue of git messenger, but thanks any way~

This isn't a real problem, but also not very nice: if the Commit: <commit-hash> line is the longest, it does not get respected on the floating window width calculation. Instead the width is too small and I get the commit hash is on a new line. Similar goes for long Author: <author> lines, which also break into a new line instead of a more wide window with the full author in one line. It would be just more pretty. I add two screenshots with examples (my colorscheme it not optimal for this atm).

Commit hash on new line:

Author line break:

I installed via minpac.

Went to give this a try and pressed <leader>gm and got nothing. :GitMessenger<CR> works though.

I'm on the latest Vim provided by Homebrew on macOS (8.1).

Any ideas why this wouldn't work out of the box? I checked my mappings and, as far as I can tell, I don't have anything mapped to <leader>gm or even <leader>g.

may i suggest adding a configure option to define the maximum popup window size? this will help to show the window better when the message itself is too long.

Derived from #3.

Repro

:edit README.md
:GitMessenger
:GitMessenger
:bnext

Expected behavior

Popup closes

Actual behavior

Popup window is still showing up and its buffer is README.md (original buffer was wiped out)

Git messenger cant seem to find the .git file, no idea why
s:find_dotgit and gitmessenger#git#root_dir return the correct result outside the plugin.

Repro

:GitMessenger
:vsplit
:wincmd p
:wincmd p
:wincmd p
...

Expected behavior

Popup is closed automatically when cursor is moved to another window

Actual behavior

Popup is not closed

In commit f6fa25a, new keybindings are added: h and l for browsing prev/next commit on the line. This feature is so nice, but I feel the default keybinding is somewhat unnatural to me as h and l are also the keys for cursor movement. Please consider switching to another keys by default.

It would be also great to have those keymaps configurable, using <Plug> mappings.

Version info: neovim 0.5.0
git: 1.8.3.1
system: CentOS 7.4

When using the default mapping <leader>gm to show message a line: I am seeing the following error:

git-messenger: Unknown option: -C usage: git ....

I think it is because the git version is not so up to date. Can we use --git-dir and --work-tree option instead of -C?

Vim version

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
including patch: 1-1453

This plugin works perfect on Neovim. but on Vim 8, the preview window will crash on the moment it is created if I set updatetime to 100.

Is this a bug of Vim? Do we have a solution for the problem?

Love this plugin, however, at some point, the floating window just got huge/oversized and won't size to the content itself. I've tried setting the g:git_messenger_max_popup_height and g:git_messenger_max_popup_width plugin preferences, but they don't seem to make a difference. CoC and other popup/floating window plugins seem to be fine. Any thoughts of what I might look at/adjust to try and fix?

When I try it in a worktree I see something like:
git-messenger: fatal: '/usr/scratch/<snip>' is outside repository :git --no-pager blame /usr/scratch/ -L 86,+1 --porcelainexited with non-zero status 128

If I do it in the main directory I don't see this issue.

Thanks you, this is an awesome plugin! Since I can view the specific commit history with it. It would be better that this plugin supports viewing the changed content.

Most people as well as I commonly use vim-fugutive's command Gvdiff to view the not yet staged content. Besides, we use vim-mundo to view the history.

Now there might be a plugin which allow us to view the changed content within a commit. How do you think about this?

I think the problem comes from .gitconfig:

[color]
  ui = always

Is it possible to make this compatible with git-messenger?

Side note: it'd be great if the diff could work with https://github.com/so-fancy/diff-so-fancy. I'm not sure if it's possible since it uses git pager.

https://github.com/vim/vim/blob/master/runtime/doc/popup.txt

It seems about to be being implemented. If it works and sufficient for this plugin, using it would be better for Vim users.

sometimes committer time is more meaningful, because it's the time when patch into team's history.

If you perform a :GitMessenger on a file that has no HEAD then you get a very convoluted error message.
Error below:

Error detected while processing function <SNR>204_on_exit_vim[2]..<SNR>204_git__may_finalize_vim[10]..<SNR>203_blame__after_blame:
line    8:
E605: Exception not caught: `git --no-pager blame /home/mikey/code/node/test/src/support/api/etfs.api.js -L 3,+1 --porcelain` exited w
ith non-zero status 128: fatal: no such ref: HEAD
Error detected while processing function <SNR>204_on_exit_vim[2]..<SNR>204_git__may_finalize_vim:
line   10:
E171: Missing :endif
Press ENTER or type command to continue

ideally the error message could be more friendly.

This just started happening with the latest update. When you run :GitMessenger, all of the ~ characters in the left margin change colors in all buffers. In my case, they change from grey to white.

BEFORE

AFTER

I also removed all of my personal config to see if that changed anything, but that did not help.

I was pondering if it is possible to use our colorscheme to choose a background color for the popup.
I use Gruvbox, which has variations of its main background color, that would be useful.
I made an issue here: morhetz/gruvbox#278
I think coc.nvim uses Pmenu as its highlight group, which seems to work fine.

When using o and O to move through the commit history if the last commit is reached the following message is shown:

git-messenger: The latest commit

On the other hand when the first commit is reached and o is pressed again the following error shows:

git-messenger: fatal: no such path vim/init.vim in 238b69d88d84f13a746f8be64c9b15fc736a9748 : `git ...edro/git-repos/private/dotfiles/vim/init.vim -L 360,+1 --porcelain` exited with non-zero status 128

Is that a feature? Isn't it better to show a message like git-messenger: Already at oldest commit? Thanks!

I think it would be useful to show the total number of revisions in the History: #0 text:

Something like History: #0 (0/2). What do you think? Thanks!

Giving a full path to msys/git doesn't seem to work well.
When :GitMesseger is executed on the C:\Users\hokorobi\vimfiles\vimrc, it will be as follows.

git-messenger: fatal: 'C:\Users\hokorobi\vimfiles\vimrc' is outside repository at '/home/hokorobi/vimfiles': `git --no-pager blame C:\Users\hokorobi\vimfiles\vimrc -L 1,+1 --porcelain` exited with non-zero status 128

When I try to call git-messenger in a submodule it fails with an error like:

git-messenger: fatal: no such path 'path/to/submodule/path/to/file' ... exited with non-zero status 128

To explain a little more:

path/to/submodule is the path to the sub module from the top-level repository (containing .git).
path/to/file is the path to the file from where I am calling git-messenger relative to submodule directory.

I am using vim-rooter to automatically change into project root directories identified by .git directory/file, Now, submodules are special, because they also contain a .git file, but this is just a text file containing the path to the submodule git directory like this:

gitdir: relative/path/to/toplevel_repo/.git/modules/path/to/submodule

vim-rooter behaves correctly by changing into path/to/submodule which is what I want most of the time. So when I open a file inside the submodule vim automatically changes into the directory of the submodule. Git-messenger however resolves the path up until the top-level repo and of course, the path/to/submodule/path/to/file doesn't exist relative to the current submodule directory, giving the above error.

I think a fix for correctly finding .git was introduced for git worktrees in this commit. Maybe this can be extended to also handle submodules.

Hi, I got some errors after calling :GitMessenger function. Here is the error.

Error detected while processing function <SNR>112_on_exit_nvim[2]..<SNR>111_blame__after_log[21]..<SNR>111_blame__open_popup[31]..<SNR>110_popup__open[5]..<SNR>110_popup__window_size:
line    2:
E117: Unknown function: win_screenpos
Press ENTER or type command to continue
Error detected while processing function <SNR>112_on_exit_nvim[2]..<SNR>111_blame__after_log[21]..<SNR>111_blame__open_popup[31]..<SNR>110_popup__open[5]..<SNR>110_popup__window_size:
line    2:
E15: Invalid expression: win_screenpos(bufwinnr(self.opener_bufnr))
Press ENTER or type command to continue
Error detected while processing function <SNR>112_on_exit_nvim[2]..<SNR>111_blame__after_log[21]..<SNR>111_blame__open_popup[31]..<SNR>110_popup__open:
line    5:
E714: List required
Press ENTER or type command to continue

I'm using neovim 0.3.1. Any help is appreciated. Thank you