doesn't find the .git folder when starting vim from a subfolder about git-messenger.vim HOT 8 CLOSED

I think the problem is caused by this line:

When file is empty, then fnamemodify(file, ':p') returns the full path of the cwd. This means that in some cases this can end up being wrongly set as dotgit instead of dir, which makes git-messenger fail with the "not in a git repo" error.

Changing the line to:

let file = empty(file) ? '' : fnamemodify(file, ':p')

fixes this for me, but I haven't verified if this still works for the submodules case (which I think is the reason why this was introduced). Maybe a similar check should be done for let dir = fnamemodify(dir, ':p') too.

from git-messenger.vim.

Closing as I could confirm the fix.

from git-messenger.vim.

I was working on another PR which just browse up till oblivion. But I’m fully new to vimscript , and I have no idea how to have the same behavior In Windows world. @rafikdraoui ‘s seems like a much better option.

from git-messenger.vim.

@rhysd could you fix this?
Could @rafikdraoui solution do the trick?

Great plugin btw!

from git-messenger.vim.

I'm sorry for the delay. I was fixing critical issue at github-action-benchmark and prioritized moving CI to GitHub Actions.

I'm not reproducing this issue, but @rafikdraoui's comment looks helpful. I'll try to fix this.

from git-messenger.vim.

@ylmrx @MeisterTea @rafikdraoui Since I'm not understanding how to reproduce this, would you check 422a933 fixed this issue?

from git-messenger.vim.

I can confirm that 422a933 fixes this for me. Thanks!

Here's how I can reproduce the bug with commit d238582 (the one just before the fix). I don't have time to test with a minimal config (i.e. perhaps my vimrc or other plugins are interfering) or with vanilla vim, but maybe this could still be helpful:

$ git clone [email protected]:rhysd/git-messenger.vim.git
$ cd git-messenger.vim
$ nvim autoload/gitmessenger.vim

Then inside NeoVim:

:GitMessenger  " this works
:cd autoload
:GitMessenger  " this doesn't work

from git-messenger.vim.

@rafikdraoui Thank you for the detailed steps. It is very helpful for me. I also could confirm this issue was fixed by 422a933 on my local machine. I did not notice this issue because I usually set the current directory to a root of repository. I think I should add more test case to confirm relative paths work properly.

from git-messenger.vim.