Commit hash always on new line about git-messenger.vim HOT 11 CLOSED

Okay, totally fine. Take your time, nothing urgent. 🙃

from git-messenger.vim.

Yes it works like charm now. 😊
@alfunx thanks for your investigation and the fix!
@rhysd thanks for the nice help for this issue. 👍

from git-messenger.vim.

Thank you for reporting this. It sounds a bug on calculating width of the window. Let me check.

from git-messenger.vim.

I tried on my project, but could not reproduce this:

Case1: Commit hash line is the longest

Case2: Author line is the longest:

Maybe some option in vimrc causes this issue.

from git-messenger.vim.

@weilbith Can I try in the same situation? If ok, please let me know:

• Repository URL you could reproduce this issue
• Git commit hash
• File path you opened

from git-messenger.vim.

And please check if you set g:git_messenger_max_popup_width. The default value is v:null

:echo g:git_messenger_max_popup_width

from git-messenger.vim.

Hey, thanks for you help!

And please check if you set g:git_messenger_max_popup_width. The default value is v:null

I can confirm that this is not set by myself and the output is the default value.

@weilbith Can I try in the same situation? If ok, please let me know:

Here we go:

• poanetwork/blockscout
• master
• apps/block_scout_web/assets/css/components/_navbar.scss
  • calling it on line 7 places the commit hash on the next line
  • on line 8 it looks fine
  • line 14 shows an example of a NL for the author.

My screen is wide enough. It floating window(s) should by far not reach the maximum possible width.

from git-messenger.vim.

@rhysd can you reproduce my issue with the given instructions?

from git-messenger.vim.

Thank you for the information. I'm sorry for the delay, I don't have sufficient time to look into this. But I think I can try this weekend.

from git-messenger.vim.

@weilbith I could narrow it down to set foldcolumn=3 (in https://github.com/weilbith/vim-blueplanet/blob/master/options.vim#L127). Removing that fixes this issue, which suggests this option is also set for the popup.

@rhysd A possible (and IMO clean) solution could be to set 'style': 'minimal' in the configuration for nvim_open_win(), e.g. in https://github.com/rhysd/git-messenger.vim/blob/master/autoload/gitmessenger/popup.vim#L108-L115. The minimal style is most useful when "displaying a temporary float where the text should not be edited" (from :h nvim_open_win()).

from git-messenger.vim.

@alfunx

Thank you so much for narrowing down this issue. I could not notice the option because I set 0 to foldcolumn. I'm not sure that the option is root cause of this issue, but I could see the unintended line wrapping with set foldcolumn=3.

@weilbith

Would you update this plugin to the latest and check if this issue still happens in your local or not. If it still happens, I'll reopen this issue.

from git-messenger.vim.