Fade & replay gain about squeezelite HOT 2 CLOSED

I reverted the change because the patch I was provided to attempt to fix the compiler warning completely broke crossfade.
After spending some time digesting your excellent description, I agree with your assessment of what the check should be so I've made the following change to output.c and crossfade still seems to be working as expected.

@@ -152,7 +152,7 @@
IF_DSD(
output.dop = output.next_dop;
)

•                           if (!output.fade == FADE_ACTIVE || !output.fade_mode == FADE_CROSSFADE) {
  

•                           if (output.fade == FADE_INACTIVE || output.fade_mode != FADE_CROSSFADE) 
  

{

Thank you for taking the time to report your fixes back to me. Change committed at 3028f38

from squeezelite.

Thanks :-) What bothered me is that with the existing test, crossfade should not work when there is replaygain. I did explicity test it and the replaygain of the next track was applied to the current track when doing the crossfade, so with a big difference between the current and next, it was very audible. I'm surprised nobody ever complained, hence I was nervous my analysis was wrong. But I did checked the same 2 tracks with a big replay gain difference with old and new test and definitevly saw that new one works, old one does not ...

from squeezelite.