nephila / djangocms-installer Goto Github PK

I ran into the situation that the installer fails at the end when Pillow is not compiled / installed with libjpeg support.

There are two things I'd like to propose that could be done to help users getting along wih this:

• check if libjpeg is there before installing pillow - because we already know it will fail otherwise
• if the former is not possible or hard to do (it might be hard to detect properly if the dev files are there on all platforms you might want to support, but it might also be possible, I'm not a C lib expert) - there should be at least a better hint on what is to do - install libjpeg-dev or some similar package, uninstall pillow, delete all remaninders from the previous aldryn run (project dir, manage.py), run aldryn again

When using django 1.5.5 instead of for example 1.5, and not giving the -p option, there is an error - and not exactly one that helps users to understand what's happening.

It just says - after a few seconds of nothing happening:

Error while creating target project, please check the given configuration

It should be saying that since django 1.5.5 -p must be given - or better, we might implement it differently, and use the project name as default, and male -p optional if the user wants it differently.
It's not uncommon or django projects that the project and main app have the same name.

Add argument to select a django project template (to be passed to django-admin)

In the tests for the configuration checks there are multiple assertions that are never executed.

Reason for this is that they are indented to be part of the with block, while they must be outside, after the with block to actually be executed.

I tried to fix that, but after getting the assertions to be executed, I fail to get them to be run properly. I might not yet have fully understood how the mock.patch that is used there works, so I guess that need to be figured out.

Failure:
raise TemplateDoesNotExist(name)
"django.template.base.TemplateDoesNotExist: fullwidth.html"

Defect:
in file: djangocms_installer/django/init.py
method: _build_settings(config_data):

relevant buggy code:

if config_data.bootstrap == 'yes':
cms_templates = 'CMS_TEMPLATES_BOOTSTRAP'
else:
cms_templates = 'CMS_TEMPLATES'

Should be:

if config_data.bootstrap:
cms_templates = 'CMS_TEMPLATES_BOOTSTRAP'
else:
cms_templates = 'CMS_TEMPLATES'

$ Languages to enable. Option can be provided multiple times, or as a comma separated list: en,de

ends up with these languages:

• e
• n
• ,
• d
• e

also tried:

• "en","de" -> " becomes a language too
• en;de

but they didn't work either

Using a ini file will make easier to create repeatable installations

See django-cms/django-cms#3082

(env)[rui@alarm demo]$ python starting_page.py
Traceback (most recent call last):
File "starting_page.py", line 15, in
with open('starting_page.json') as data_file:
FileNotFoundError: [Errno 2] No such file or directory: 'starting_page.json'

On Ubuntu 13.04 Raring, in version 0.3.4, when running the installer with the values suggested in the tutorial:

SITE_ID, STATIC_ROOT, STATICFILES_DIRS are all created twice.
BASE_DIR is created once, only referenced when setting STATIC_ROOT (which overwrites the previously set value of STATIC_ROOT). Does BASE_DIR need to exist if PROJECT_PATH already exists?

Also, PROJECT_PATH is set to the my_demo subdirectory containing settings.py rather than its parent directory containing manage.py. Is this deliberate? Isn't PROJECT_PATH normally set to the root project directory?

(env)[rui@alarm demo]$ python starting_page.py
Traceback (most recent call last):
File "/usr/lib/python3.3/site-packages/django/conf/init.py", line 38, in _setup
settings_module = os.environ[ENVIRONMENT_VARIABLE]
File "/home/rui/workspace/demo/env/lib/python3.3/os.py", line 676, in getitem
raise KeyError(key) from None
KeyError: 'DJANGO_SETTINGS_MODULE'

ownloading/unpacking django-cms from https://github.com/divio/django-cms.git@develop
HTTP error 404 while getting https://github.com/divio/django-cms.git@develop
Could not install requirement django-cms from https://github.com/divio/django-cms.git@develop because of error HTTP Error 404: Not Found
Cleaning up...
Could not install requirement django-cms from https://github.com/divio/django-cms.git@develop because of HTTP error HTTP Error 404: Not Found for URL https://github.com/divio/django-cms.git@develop
Storing complete log in /Users/patricklauber/.pip/pip.log
Traceback (most recent call last):
File "/Users/patricklauber/Documents/workspace/test_project/env/bin/aldryn", line 8, in
load_entry_point('aldryn-installer==0.1.0', 'console_scripts', 'aldryn')()
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/main.py", line 22, in execute
install.check_install(config_data)
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/install/init.py", line 52, in check_install
raise EnvironmentError("\n".join(errors))
EnvironmentError: Pillow is not installed check for installation errors

It would be really nice if the installer checked the connection to the database before asking anything else. This way the information typed after the database url won't just be dropped if the connection fails.

You need to make sure the python extensions and filetype are associated correctly and to the current virtualenv. Currently, windows just uses the globally install python.

C:\Windows\system32> assoc .py=Python.file
.py=Python.file

and

C:\Windows\system32> ftype Python.File="C:\Users\Username\workspace\demo\env\Scripts\python.exe" "%1" %*
Python.File="C:\Users\Username\workspace\demo\env\Scripts\python.exe" "%1" %*

Add support for plugins removed from CMS core

I installed django-cms dev 14 with django 1.6 and filer plugins using djangocms-installer . cmsplugin_filer_image is not in settings.py and so it is not available in the browser in frontend.
Also MEDIA_URL and MEDIA_ROOT are not defined in settings.py , which is not explained in tutorial on using djangocms-installer.

Only language code are allowed

Waiting for RC1 release

Successfully installed django-classy-tags south html5lib Pillow django-mptt django-sekizai Django django-reversion djangocms-text-ckeditor djangocms-admin-style djangocms-column djangocms-style django-cms
Cleaning up...
CommandError: 'test' conflicts with the name of an existing Python module and cannot be used as a project name. Please try another name.
Traceback (most recent call last):
File "/Users/patricklauber/Documents/workspace/test_project/env/bin/aldryn", line 8, in
load_entry_point('aldryn-installer==0.1.0', 'console_scripts', 'aldryn')()
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/main.py", line 23, in execute
django.create_project(config_data)
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/django/init.py", line 31, in create_project
raise EnvironmentError(message)
EnvironmentError: Command '['django-admin.py', 'startproject', 'test']' returned non-zero exit status 1

Also i think no static folder is created and collect_static not run.

Ship richer html templates to make things easier for newbies.

As suggested by @henning, have a look at mezzanine installer.

Up until the point where the installer runs some database stuff, the user can sit a few seconds or longer (e.g. when network is slow and dependencies are installed) in front of the command, appearing nothing is happening.

Even without verbose option chosen, there should be some message to the user that aldryn installer is actually doin something.

It miught also be interesting to only print out all the other stuff - database migrations and such, when verbosity is requested, oitherwise just a short message "running migrations", "installing dependencies" , etc.

File "/Users/patricklauber/Documents/workspace/test_project/env/bin/aldryn-installer", line 8, in
load_entry_point('aldryn-installer==0.1.0', 'console_scripts', 'aldryn-installer')()
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/main.py", line 13, in execute
config_data = config.parse(sys.argv[1:])
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/config/init.py", line 118, in parse
requirements.append(args.db_driver)
AttributeError: 'Namespace' object has no attribute 'db_driver'

When I use "djangocms -p . my_demo", and the error ocurr.

I believe that all config options should have a default, and in fact, in the interactive run, they have.

As such, when running on the command line with -q, I expect the installer to use defaults where I don't specify anything explicitly.

I think that's the most convenient way for everybody to deal with.

Like this people can write scripts to fully automate a new project setup with minimum effort, as they only need to specify non default values, at the same time everybody wanting to specify anything can still do so.

Let user pass a URL or path to get templates and static files from

atabase configuration (in URL format) [default sqlite://locahost/project.db]:
django CMS version (choices: 2.4, stable, beta, develop) [default stable]: develop
Django version (choices: 1.4, 1.5, stable) [default stable]: 1.5
Activate Django I18N / L10N setting (choices: yes, no) [default yes]: yes
Install and configure reversion support (choices: yes, no) [default yes]:
Languages to enable. Option can be provided multiple times, or as a comma separated list: de,fr
Optional default time zone [default America/Chicago]:
Activate Django timezone support (choices: yes, no) [default yes]:
Activate CMS permission management (choices: yes, no) [default yes]:
Downloading/unpacking https://github.com/divio/django-cms/archive/develop.zip
Downloading develop.zip (2.7MB): 2.7MB downloaded
Running setup.py egg_info for package from https://github.com/divio/django-cms/archive/develop.zip

warning: no files found matching '*' under directory 'stacks/templates'
warning: no previously-included files matching '*.pyc' found under directory '*'

Requirement already satisfied (use --upgrade to upgrade): django-classy-tags>=0.3.4.1 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): south>=0.7.2 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): html5lib in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): Pillow>=2 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): django-mptt>=0.5.1,<0.5.3 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): django-sekizai>=0.7 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): Django<1.6 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): django-reversion>=1.7,<1.8 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): djangocms-text-ckeditor>=2 in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): djangocms-admin-style in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): djangocms-column from git+https://github.com/divio/djangocms-column.git#egg=djangocms-column in ./env/lib/python2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): djangocms-style from git+https://github.com/divio/djangocms-style.git#egg=djangocms-style in ./env/lib/python2.7/site-packages
Cleaning up...
Traceback (most recent call last):
File "/Users/patricklauber/Documents/workspace/test_project/env/bin/aldryn", line 8, in
load_entry_point('aldryn-installer==0.1.0', 'console_scripts', 'aldryn')()
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/main.py", line 24, in execute
django.patch_settings(config_data)
File "/Users/patricklauber/Documents/workspace/test_project/env/lib/python2.7/site-packages/aldryn_installer/django/init.py", line 59, in patch_settings
with open(config_data.settings_path, 'r') as fd_original:
IOError: [Errno 2] No such file or directory: 'test_project/settings.py'

or aldryn_installer (at the moment: aldryn-installer)

Hello!

I have both Python versions installed on my CentOS (2.6.6 and 3.3). I would prefer running Django CMS under Python 3.3. Installation works fine until setup_database calls:

subprocess.check_call(["python", "-W", "ignore", "manage.py", "syncdb", "--all", "--noinput"])

Since "python" command runs Python 2.6.6, for which django is not installed, it fails with "No module named django.core.management" error.

Executing the command manually with python3 fails because of those renamed Django CMS plugins (already reported).

Thank you for making this tool, it will simplify the installation a lot!

Michal

With a simple basic install, I realize that we end uo having the normal "index.html" template - which I do not yet see how it should be used in this blank state, and there's a page.html - which cannot be used for anything as trying to use it(e.g. by default when adding a page through the API that wants to use it) results in an error about the extended template not existing.

I'll go and make a fix for it today or tomorrow when ready with some other stuff.

Hi,
I got this error when I was trying to install django-cms using djangocms-installer.
I set a “Hobby Dev Heroku Postgres” database url.
Os x, Python 2.7.6, pip==1.5.4 and virtualenv==1.11.4

...
Creating admin user
Username (leave blank to use 'oubiga'): 
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/core/management/__init__.py", line 399, in execute_from_command_line
    utility.execute()
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/core/management/base.py", line 242, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/core/management/base.py", line 285, in execute
    output = self.handle(*args, **options)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/contrib/auth/management/commands/createsuperuser.py", line 102, in handle
    self.UserModel._default_manager.db_manager(database).get_by_natural_key(username)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/contrib/auth/models.py", line 167, in get_by_natural_key
    return self.get(**{self.model.USERNAME_FIELD: username})
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/manager.py", line 151, in get
    return self.get_queryset().get(*args, **kwargs)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/query.py", line 301, in get
    num = len(clone)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/query.py", line 77, in __len__
    self._fetch_all()
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/query.py", line 854, in _fetch_all
    self._result_cache = list(self.iterator())
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/query.py", line 220, in iterator
    for row in compiler.results_iter():
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 713, in results_iter
    for rows in self.execute_sql(MULTI):
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 786, in execute_sql
    cursor.execute(sql, params)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/backends/util.py", line 69, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/backends/util.py", line 53, in execute
    return self.cursor.execute(sql, params)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/utils.py", line 99, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/django/db/backends/util.py", line 53, in execute
    return self.cursor.execute(sql, params)
django.db.utils.DatabaseError: SSL SYSCALL error: Operation timed out

Traceback (most recent call last):
  File "/Users/oubiga/Envs/uxiolopezvenv/bin/djangocms", line 11, in <module>
    sys.exit(execute())
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/djangocms_installer/main.py", line 29, in execute
    django.setup_database(config_data)
  File "/Users/oubiga/Envs/uxiolopezvenv/lib/python2.7/site-packages/djangocms_installer/django/__init__.py", line 263, in setup_database
    "manage.py", "createsuperuser"])
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/Users/oubiga/Envs/uxiolopezvenv/bin/python', '-W', 'ignore', 'manage.py', 'createsuperuser']' returned non-zero exit status 1```

Allow user to pass extra settings argument to the installer to be merged in the generated settings file.
This is a future proof feature that enable user to provide settings required by newer version of a dependency than the one the installer has been tested on (see the easy-thumbnails 2.0 thing)

This test is just a copy paste from the other one - only differring in the one, unexecuted(see our latest learnings about the with/assertRaises) assertion

If I can get an understanding of what it's supposed to test for, I can implement it properly, but it has no docstring to explain it's intended functionality.

Otherwise I'd just like to remove it.

using virtualenv and following the tutorial for djcms 3.0 beta3 the path it was looking in for images was:
/home/rui/workspace/demo/env/lib/python3.3/site-packages/djangocms_installer/install/../share/test_image.png
and although the share directory was there, the png file was not, it should do an os.path.exists(file) first