test_whitespace_project_path in tests/config.py is a copy of test_invalid_project_path about djangocms-installer HOT 4 CLOSED

Move the assert from test_whitespace_project_path to test_whitespace_project_path, we can safely remove it

from djangocms-installer.

I dont understand the first part - move from X to X?
Am 05.11.2013 10:36 schrieb "Iacopo Spalletti" [email protected]:

Move the assert from test_whitespace_project_path to
test_whitespace_project_path, we can safely remove it

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/38#issuecomment-27762580
.

from djangocms-installer.

Sorry, typo! :)
I meant from test_whitespace_project_path to test_invalid_project_path
Assertion at https://github.com/nephila/aldryn-installer/blob/master/tests/config.py#L152 is different from the one at test_invalid_project_path and both are needed, but they can easily merged into one test

from djangocms-installer.

I see that extra assertion that is the difference between the two methods, but looking clearly at them - the assertion in the whitespace method just can not work!

It checks for a variable that cannot and must not exist as it's set with a statement that we ant to lead to an exception - that's what we test for.

The only reason why the whitespace test method doesn't lead to an error is because the assertion is never executed because an Exception happens before it comes to the execution.

from djangocms-installer.