nasa / earthdata-search Goto Github PK

Please review Contribution.md before contributing to this project.

Description

Files

Acceptance Criteria

Fix 'Multiple form label' for all findings to be 508 compliant.

Please review Contribution.md before contributing to this project.

Description

The feature facet named "Available from AWS Cloud" should be renamed to "Available in Earthdata Cloud"

Acceptance Criteria

Facet in EDSC is visible as 'Available in Earthdata Cloud'

Description

When updating preferences, surface a confirmation message to the user that their preferences have been saved or if a problem occurred.

Acceptance Criteria

• Upon success, inform the user their preferences have been saved
• If an error occurs saving the preferences, inform the user that an error has occurred
  • If there is something the user can do to rectify the error, inform them what they can do

Is your feature request related to a problem? Please describe.
In the sidebar, there is a section called Keywords. In this section, we can apply multiple filters, but there isn't any button to remove all the features at once, like there is a feature of Clear Filters in Filter Granules.

Describe the solution you'd like
It would be better if we can remove all the filters at once in Keywords section too.

Please review Contribution.md before contributing to this project.

Description

Files

Acceptance Criteria

Fix 'Empty heading' for all findings to be 508 compliant.

Description

Add keyboard shortcut to focus on the search bar input field when on a page that supports search (/search, /search/granules).

The / button should be used for this shortcut.

Acceptance Criteria

• When on a search supported page (/search, /search/granules), hitting the / button on the keyboard focuses on the search input field.
• When not on a search supported page (/search, /search/granules), hitting the / button on the keyboard has no impact on the application.

Description

Some collections consist of granules that are "multi-file" granules. In this case, clicking the "Download single granule data" button should display a dropdown of the available files to download. This is not working when a user is in the table view on the granules panel.

Reproduction Steps

1. Search for a collection that has multi-file granules and click on it to load granules (NSIDC-0481 Prod environment)
2. Click on the download icon in the list view and observe that multiple files appear
3. Switch to table view using the toggle in the top-right of the granules panel
4. Click on the download icon in the table view and observe that nothing happens

Acceptance Criteria

1. Search for a collection that has multi-file granules and click on it to load granules (NSIDC-0481 in Prod)
2. Click on the download icon in the list view and observe that multiple files appear
3. Confirm that clicking on those links downloads the intended file
4. Switch to table view using the toggle at the top of the granules panel
5. Click on the download icon in the table view and observe that multiple files appear
6. Confirm that clicking on those links downloads the intended file

Description

In an effort to improve initial load times, we should lazy load the Timeline component. We want to be sure to do this in a way that does not degrade the UX of the initial application load.

Acceptance Criteria

• Timeline javascript is only loaded in pages that render the timeline (/search/granules, /project)

I was thinking the install and setup could be improved for Ubuntu and other Linux distros by having a snap package version. If it's not a priority would you mind if I made the snap as a contribution?

Crafting your first snap

Build and test snap

Getting Started snap template

The README states the following

Run

    bin/setup

Note: This command will take a long time to run

### Application configuration

Review `config/application.yml` and update values as necessary

#### (Optional) Earthdata Login (URS) Configuration

I have an issue with this, if you just execute bin/setup, you are WARNed that you should copy config/application.yml.example and config/database.yml.example to formal files at config/application.yml and config/database.yml respectively. This means that once I do that, I then need to go back and configure the deployment however this should be done prior to me running bin/setup!

Additionally, I would strongly suggest that we encourage folks to sign up for URS rather than stating it as an optional step. The reason I say this, is as follows. Say they first run bin/setup, then go and create deployment-specific manifestations of config/application.yml and config/database.yml, based on the logic of the README, they still would again have to go back and add configure URS details if they have not already done that. This seems somewhat convoluted and I think it should be streamlined.

If we can agree, then I'll go ahead and get a quick PR submitted. Any thoughts?

Talking with @littleidiot40 I was talked through the creation of a new portal. This issue will provide the basis for creation of a new PO.DAAC portal which will reside at https://search.earthdata.nasa.gov/portal/podaac/search

PR coming up!

Please review Contribution.md before contributing to this project.

Description

Findings using SortSite. SortSite was run locally with Tophat removed and robots.txt allowing PowerMapper.

SortSite can be downloaded/accessed here: https://inside.nasa.gov/webservices/support/section-508-testing-sortsite

Files

Acceptance Criteria

Fix 'element must contain ALT attribute' for all findings from SortSite to be 508 compliant.

I would assume other people would like to contribute to this project. Are there any issues which can be opened?

Please review Contribution.md before contributing to this project.

Description

Acceptance Criteria

Fix 'Broken ARIA reference' for all findings to be 508 compliant.

Please review Contribution.md before contributing to this project.

Description

Files

Acceptance Criteria

Fix 'Empty form label' for all findings to be 508 compliant.

Please review Contribution.md before contributing to this project.

Description

We should implement a nicer loading state similar to the ones elsewhere in the application. Either the pulsing 3 ellipses (like when viewing download history) or the pulsing content skeleton (like on granules panel) will work.

Acceptance Criteria

1. Loading state for collections is in line with loading states throughout the application.

Description

Currently we use a font-awesome package from npm which imports Font Awesome as a font. To improve performance, we should replace this with an svg library like react-icons. We should create an Icon component which will dynamically import react-icons, allowing us to add/remove libraries as needed. The component should accept className, library, and icon as props. Initially, only the Font Awesome library will be used.

Acceptance Criteria

• All instances of <i> icon elements replaced with EDSCIcon component
• No visual changes to current icons

Description

Add keyboard shortcut to toggle granule filters when looking at granules. This should only be active when looking at /search/granules...

The g button should be used for this shortcut.

Acceptance Criteria

• When on the granules page (/search/granules), hitting the g button on the keyboard toggles the granule filters panel active/inactive.
• When not on the granules page, hitting the g button on the keyboard has no impact on the application

Please review Contribution.md before contributing to this project.

Description

Files

Acceptance Criteria

Fix 'Missing form label' for all findings to be 508 compliant.

Description

Add keyboard shortcut to toggle timeline when on a page that displays the timeline (/search/granules, /projects).

The t button should be used for this shortcut.

Acceptance Criteria

• When on the granules or project page (/search/granules, /projects), hitting the t button on the keyboard toggles the timeline active/inactive.
• When not on the granules or project page, hitting the t button on the keyboard has no impact on the application
• Add t: 'Toggle timeline' to KeyboardShortcutsModal.js
• When a user is typing into any input field, hitting the t button does not trigger the shortcut

Description

In an effort to improve initial load times, we should lazy load Leaflet js. We want to be sure to do this in a way that does not degrade the UX of the initial application load.

Acceptance Criteria

• Leaflet/map javascript is only loaded in pages that render the map (/search/*, /project)
• Once the map component is mounted/rendered, it should not be remounted

Description

When dropping a shapefile that crosses the antimeridian onto EDSC, the polygon that gets drawn and sent to CMR be broken up into two parts, with each part being placed on the appropriate side of the map. The shapefile (shown in orange) should also follow this same behavior.

Example Shapefile
alaska-shapefile.kmz.zip (Unzip this file and drop onto the map)

Acceptance Criteria

• When a shapefile is used that crosses the antimeridian, it is broken up and placed on the other side of the meridian.
• When a shapefile is used that crosses the antimeridian, the polygon sent to CMR for spatial search is placed on the other side of the meridian

Description

Cannot remove search from granule search box. Deleting text and hitting 'Enter' causes the page to reload with the text re-populated.

Reproduction Steps

1. Visit https://search.uat.earthdata.nasa.gov/search/granules?p=C447308-ORNL_DAAC&pg[0][gsk]=-start_date&tl=1585761296!4!!
2. Copy/paste "1860_1993_2050_NITROGEN.N-deposition2050.txt" into the granule search field
3. Observe that only a single granule is returned
4. Delete the text in the granule search field and press enter
5. Observe that the page refreshed, the text just deleted remains, and only a single granule is returned

Acceptance Criteria

1. Load any collection with granules
2. Copy/paste any of the granule titles into the search field and observe that the filter works as intended
3. Remove the granule search text and observe that no granule filter/search is applied and all expected granules return

Although issues installing pow should be reported elsewhere, I wanted to open an issue here seeing as it is listed as a prerequisite recommendation.

Please review Contribution.md before contributing to this project.

Description

Findings using SortSite. SortSite was run locally with Tophat removed and robots.txt allowing PowerMapper.

SortSite can be downloaded/accessed here: https://inside.nasa.gov/webservices/support/section-508-testing-sortsite

Files

Acceptance Criteria

Fix 'FIELDSET elements labeled with LEGEND elements' for all findings from SortSite to be 508 compliant.

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    C:/RailsInstaller/Ruby2.1.0/bin/ruby.exe -r ./siteconf20150818-11932-hb24zj.rb extconf.rb
Command 'qmake -spec win32-g++ ' not available

Makefile not found

Gem files will remain installed in C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/bundler/gems/capybara-webkit-042822d7
c6f7 for inspection.
Results logged to C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/bundler/gems/extensions/x86-mingw32/2.1.0/capybara-web
kit-042822d7c6f7/gem_make.out
An error occurred while installing capybara-webkit (1.1.1), and Bundler cannot
continue.
Make sure that `gem install capybara-webkit -v '1.1.1'` succeeds before
bundling.

This is the error I get when I try to run bundle install. It seems like a common issue. I installed Qt libraries (v5.5.0), but it didn't work. Do you have a solution for this?

External Links I've already checked these.

Capybara Webkit Wiki
Stackoverflow

Environment

macOS High Sierra v10.13.6
Docker for Mac v2.0.0.0-mac81 (29211)

Issue

The Docker build eventually fails for above environment as follows

./bin/setup
...
== Preparing database (development and test environments) ==
    $ docker-compose run web bundle exec rake db:setup
Starting earthdata-search_db_1 ... done
Could not locate Gemfile or .bundle/ directory
Exiting: Error executing command docker-compose run web bundle exec rake db:setup

I've been picking the docker-compose build apart and haven't yet found any solution.

After configuring config/database.yml and config/application.yml and executing ./bin/setup after a lot of std output I get the following...

== Preparing database (development and test environments) ==
    $ docker-compose run web bundle exec rake db:setup
      -> Creating network "earthdata-search_default" with the default driver
      -> Pulling db (postgres:)...
      -> latest: Pulling from library/postgres
Creating earthdata-search_db_1 ... error
      ->
      -> ERROR: for earthdata-search_db_1  Cannot start service db: b'Mounts denied: \r\nThe path /usr/local/earthdata-search/tmp/db\r\nis not shared from OS X and is not known to Docker.\r\nYou can configure shared paths from Docker -> Preferences... -> File Sharing.\r\nSee https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.\r\n.'
      -> ERROR: for db  Cannot start service db: b'Mounts denied: \r\nThe path /usr/local/earthdata-search/tmp/db\r\nis not shared from OS X and is not known to Docker.\r\nYou can configure shared paths from Docker -> Preferences... -> File Sharing.\r\nSee https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.\r\n.'
      -> Encountered errors while bringing up the project.
Exiting: Error executing command docker-compose run web bundle exec rake db:setup

By default, Docker for Mac shares directories falling under /Users, /Volumes, /private and /tmp anything else needs to be explicitly configured within the Docker daemon. In my case the EDSC code resides within /usr/local
I think this is worthy of being be noted within the README... possibly we could introduce an installation FAQ's section.
wdyt?

Please review Contribution.md before contributing to this project.

Description

Files

Acceptance Criteria

Fix 'Empty button' for all findings to be 508 compliant.

Description

Add keyboard shortcut to toggle advanced search when on a page that supports search (/search, /search/granules).

The a button should be used for this shortcut.

Acceptance Criteria

• When on a search supported page (/search, /search/granules), hitting the a button on the keyboard toggles the advanced search modal active/inactive.
• When not on a search supported page (/search, /search/granules), hitting the a button on the keyboard has no impact on the application.

Description

Add keyboard shortcut to toggle modal that displays all supported keyboard shortcuts. The ? button should be used for this shortcut.

To make this list of shortcuts easier to maintain, a config file should be used that lists all of the keyboard shortcuts along with a short description of what each of the shortcuts do. Descriptions should be short and to-the-point.

Currently supported shortcut:

• ] - Toggle main search result/granules panel

Shortcuts with open tickets:

• g - Toggle granule filters panel
• a - Toggle advanced search modal
• / - Focus on search input field
• ? - Display all keyboard shortcuts
• t - Toggle timeline

Acceptance Criteria

• Hitting the ? button on the keyboard displays a modal that lists all supported keyboard shortcuts.

Please review Contribution.md before contributing to this project.

Description

Earthdata Search currently has the ability to sort collections by end date, but not by start date. The sort key used for this should be start_date

Acceptance Criteria

Collections can be sorted by start date.

Describe the solution you'd like
Creation of a the HiTIDE portal will reside at https://search.earthdata.nasa.gov/portal/hitide/search

After configuring config/database.yml and config/application.yml and executing ./bin/setup after a lot of std output I get the following...

== Preparing database (development and test environments) ==
    $ docker-compose run web bundle exec rake db:setup
      -> Creating network "earthdata-search_default" with the default driver
      -> Pulling db (postgres:)...
      -> latest: Pulling from library/postgres
Creating earthdata-search_db_1 ... error
      ->
      -> ERROR: for earthdata-search_db_1  Cannot start service db: b'Mounts denied: \r\nThe path /usr/local/earthdata-search/tmp/db\r\nis not shared from OS X and is not known to Docker.\r\nYou can configure shared paths from Docker -> Preferences... -> File Sharing.\r\nSee https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.\r\n.'
      -> ERROR: for db  Cannot start service db: b'Mounts denied: \r\nThe path /usr/local/earthdata-search/tmp/db\r\nis not shared from OS X and is not known to Docker.\r\nYou can configure shared paths from Docker -> Preferences... -> File Sharing.\r\nSee https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.\r\n.'
      -> Encountered errors while bringing up the project.
Exiting: Error executing command docker-compose run web bundle exec rake db:setup

This should definitely be noted within the README... possibly we could introduce an installation FAQ's section???

Description

It would be nice to improve the tooling in this project. For instance, implementing grammar, better linting and such like.

Files

N/A

Acceptance Criteria

Well written infra.

Is your feature request related to a problem? Please describe.
N/A

Additional context

Similar work done in OpenMCT (nasa/openmct#6888)

Please review Contribution.md before contributing to this project.

Description

The freetext placeholder on Earthdata Search says "Search for collections or topics", which confuses the issue. Even when you are using the Autosuggest, you are still not really searching for "topics", ultimately you are searching for data collections. Curiously, "Data" is not really mentioned on the front page of the UI. Suggest changing this phrase to "Type text to search for data"

Acceptance Criteria

Keyword search placeholder text reads "Type text to search for data".

Please review Contribution.md before contributing to this project.

Description

Findings using SortSite. SortSite was run locally with Tophat removed and robots.txt allowing PowerMapper.

SortSite can be downloaded/accessed here: https://inside.nasa.gov/webservices/support/section-508-testing-sortsite

Many of the findings here are repetitive (pointing to the footer).

Files

Acceptance Criteria

Fix 'repetitive navigation links' for all findings from SortSite to be 508 compliant.

Description

Entering spatial constraints currently zooms to the center of the entire EDSC window extent, not the current visible extent. The entire EDSC window includes space overlapping the map with the collections and facets panels.

With the default spacing of the collections and facet panels, a point is auto-zoomed/centered behind the collections panel. This may vary by browser/screen resolution/settings/etc.

This applies to all spatial search methods.

Acceptance Criteria

• When entered manually, all spatial selections are centered in the visible map area
• Shapefile spatial selections are centered in the visible map area

Please review Contribution.md before contributing to this project.

Description

The Contact Information route should use a hypen instead of an underscore to match our the other routes. ex: search.earthdata.nasa.gov/contact-info

Acceptance Criteria

Contact information url is displayed as "/contact-info"

Please review Contribution.md before contributing to this project.

Description

Findings using SortSite. SortSite was run locally with Tophat removed and robots.txt allowing PowerMapper.

SortSite can be downloaded/accessed here: https://inside.nasa.gov/webservices/support/section-508-testing-sortsite

All of these findings appear repetitive and are pointing to the same code (shapefile dropzone).

Files

Acceptance Criteria

Fix 'form control has no name' for all findings from SortSite to be 508 compliant.

Please review Contribution.md before contributing to this project.

Description

When a smart handoff is not displayed do to invalid parameters, we should inform the user by disabling the button and adding a tooltip. Currently, the Explore button is hidden completely.

Acceptance Criteria

Explore button is disabled and user is informed when the current query does not meet the requirements to display a smart handoff