EDSC-2913: Add keyboard shortcut to show all supported keyboard shortcuts about earthdata-search HOT 6 CLOSED

Yes, I will take care of that one. I have a few updates,

1. Almost finished up the implementation, just the unit tests are pending.
2. I will be introducing a new variable in the state for representing the modal state as open or closed. So, it will be required by other devs to incorporate that in their implementation. Will it be feasible or we can take an alternative approach here?

from earthdata-search.

Hi, I would like to take this up!

from earthdata-search.

The commit for our first keyboard shortcut can be found here (amongst a few other changes 😄 ). Also, note that there are a few other people tackling related tickets. We will consider consistency before accepting any PRs.

from earthdata-search.

Yes, got your point. Already checked that feature on the live site. Just a question do you want other shortcuts as disabled when the modal for shortcuts is toggled or do you want them to work as expected?

from earthdata-search.

Oh, good question. Yes, when the help modal is active, no other shortcuts should work. Following the Gmail paradigm helps here.

from earthdata-search.

Before submitting a PR, please make sure you have a test for the functionality you've added. A unit test was added for our existing keyboard shortcut with this PR. Thank you!

from earthdata-search.