EDSC-2898: Cannot remove filter from granule search box about earthdata-search HOT 3 CLOSED

I can cover this issue! Setting up a draft PR in a few ✌️

from earthdata-search.

Awesome! Thank you @heykc

from earthdata-search.

@abbottry apologies for not running the tests before pushing! I do have a question for you or anyone that would be able to answer. The test directly checks that props.onApplyGranuleFilters is called with { readableGranuleName: null } however my change directly affects what we're sending to props.onApplyGranuleFilters (sending an empty array rather than null). Obviously I don't want to just change the test so that it passes with my fix, but correct me if I'm wrong, I do believe we should be passing in an empty array rather than a null value.

If we pass a null value, we remove the null filter completely once the prunedFilters reducer runs inside of collections.js (line 116 in \static\src\js\actions\collections.js . Unless we somehow retain and pass the null filter to the UPDATE_GRANULE_SEARCH_QUERY action, we won't be able to update the state in Redux with the updated readableGranuleName value. And since an empty array is still truthy, we wouldn't be removing it in the prunedFilters reducer.

Let me know if you agree. If you do, I can make the change to the test file to expect an empty array, otherwise, I'm happy to discuss possible other actions we can take. ✌️

from earthdata-search.