EDSC-2914: Add keyboard shortcut to toggle the timeline about earthdata-search HOT 17 CLOSED

We have 1 keyboard shortcut already. That was committed here

from earthdata-search.

@adnansalik please note that there are several other people wanting to work the other keyboard shortcuts. So, please scope this commit to this one so we aren't stepping on toes.

from earthdata-search.

Go for it @marisamorby!

from earthdata-search.

Hey, can I work on this?

from earthdata-search.

Go for it @adnansalik. There are a few keyboard shortcut issues that would be nice to all go in together if you're up for it.

from earthdata-search.

Yes I noticed that, I will try to include all those issues. I'm really new to contributing so it might take a while but I'll keep you updated.

from earthdata-search.

Before submitting a PR, please make sure you have a test for the functionality you've added. A unit test was added for our existing keyboard shortcut with this PR. Thank you!

from earthdata-search.

Hey, I think I won't be able to get around this issue because something really urgent came up and I won't get enough time to work on it so I'm sorry and anyone can take this issue as I won't be working on it anymore.

from earthdata-search.

I would like to work on this issue!

from earthdata-search.

Hi @mreese84! I realized while setting this up that it's a bit above my current ability. I got to the "you need to install postgres" step and realized I was really punching above my weight. 😬

I'm sorry, but I'm going to throw this issue back in the pond for someone who's able to complete it.

from earthdata-search.

Gotcha @marisamorby, no worries.

from earthdata-search.

I'd like to give it a try on this over the weekend if that's ok :)

from earthdata-search.

Is this issue still open? Can I try? Or @taismassaro is on it?

from earthdata-search.

@mfayaq it is still open. If you want to give it a go, please do. Also, please note that after the last round of shortcut tickets were worked we had to go in and ensure typing the various shortcut keys while typing in an input field did not trigger that shortcut. We will be checking to ensure that doesn't happen with this as well.

from earthdata-search.

sorry I was waiting on a response to get started. but I guess you can go ahead then, @mfayaq

from earthdata-search.

@mfayaq it is still open. If you want to give it a go, please do. Also, please note that after the last round of shortcut tickets were worked we had to go in and ensure typing the various shortcut keys while typing in an input field did not trigger that shortcut. We will be checking to ensure that doesn't happen with this as well.

Oh I kind of miss that one. I have checked in the new code. And followed the new implementation :)

from earthdata-search.

sorry I was waiting on a response to get started. but I guess you can go ahead then, @mfayaq

No issues @taismassaro , maybe next time :)

from earthdata-search.