Audio timing.sample_rate =audio_out_rate glitch about retroarch HOT 15 CLOSED

ps: all that was tested on win32

from retroarch.

A related bug was fixed in commit: 34713f4. Make sure you're running latest versions.

from retroarch.

I am sure, tested on current git mingw compile and on beta-2

from retroarch.

Themaister: Themaister@34713f4 fixes bug in Sinc-resampler, but win32 x86 build use Hermite (only x86_64 have SINC=1 arg)

I've tested x86 build with SINC=1 and all works fine, so probably bug in that hermite-resampler.

from retroarch.

btw, why not use SINC in 32bit build ? imo it gives better result

from retroarch.

Sinc is a bit slower than Hermite due to quality, and when a user uses 32-bit it is assumed that it is because the computer is fairly old (like XP 32-bit). I cannot make sure that a x86 computer has SSE (which sinc uses extensively to gain speed) and I don't want two builds. I don't want either to switch out implementations in runtime, which is not possible when using intrinsics (I have to enable SSE in compiler to have it work with intrinsics).

from retroarch.

OK, it's your decision, but I'm not sure that there is at least one person using a PC with Pentium2 on Athlon(not XP) for emulation...

from retroarch.

If ditching support for older processors in the default builds is considered fine, I can build in SSE support and sinc ofc.

from retroarch.

Hermite should be fixed now as of latest commit.

from retroarch.

No, its still broken, but now I hear sound with kind of distortion or high freq noise effect.

from retroarch.

Still broken in what way? I verified that crackling occured, and those were gone after the commit.

If downsampling is occuring with hermite it's not going to sound good anyways (aliasing), and hermite is crap anyways at high frequencies. Input rate is usually adjusted dynamically.

from retroarch.

I mean it is still broken, but now in another way -
I hear no crackling, but kind of high freq distortion or reverberation, it is best notable on games with high tone FM music or sfx

from retroarch.

ps: with audio_rate_control = "true" this audio artifacts much less notable, but still present

from retroarch.

Yes, with hermite there will be a high frequency distortion when it's being resampled very near the Nyquist frequency, so it's not really avoidable unless expensive low-pass filtering takes place beforehand (which sidesteps the point of Hermite to begin with, speed), so I don't consider it a bug. Sinc will deal a lot better with this issue.

I've made Sinc default on x86 builds now. They will require SSE1.

from retroarch.

thanks for explanation. this issue can be closed.

from retroarch.