Menu entry with no text about retroarch HOT 14 CLOSED

The three dots are only supposed to be there when the option is a submenu, as in not a single action item, but that is not always 100% perfect. And indeed it does not belong there, so it is not missing.

from retroarch.

That indeed is not the proper way to hide the item. That only removes the action, but it should rather remove the display item in menu/menu_displaylist.c.

Now that I know that, I'll update the patch to remove the display entry from that location in the future.

from retroarch.

Searching with MENU_ENUM_LABEL_RESET_TO_DEFAULT_CONFIG points to this block:

So either add a break before that or comment out the if and the count++.

from retroarch.

Could not reproduce yet. Can you tell what version are you using (Information / System Information)?

from retroarch.

[INFO] RetroArch 1.18.0 (Git 90b960272f)
[INFO] === Build =======================================
[INFO] Funcionalidades: ASIMD
[INFO] Version: 1.18.0
[INFO] Git: 90b960272f
[INFO] Built: Mar 29 2024
[INFO] =================================================

Anbernic RG353M with ArkOS

CFG attached.
retroarch.cfg.zip

from retroarch.

While you are into it, add a > Show 'Local Network' < setting in Menu Item Visibility (is missing).
Thanks

from retroarch.

I can not reproduce via normal builds, I'm afraid. Took the relevant values from your config file, but the 4th menu entry still shows up correctly.
But there is one thing: I can not find the commit ID in RetroArch main repository (i.e. this one), so I can only assume it was built from some fork, but I could not locate the respective source for ArkOS. If you have access to that, maybe you can take a look at the copy of this specific file there:

If the value of MENU_ENUM_LABEL_VALUE_RESET_TO_DEFAULT_CONFIG is just whitespace (" "), this causes the entry to be invisible, but normally it is prevented by Crowdin and the translation export scripts, and I can not see any change in this line since 2 years.

from retroarch.

OK, I will see what I can do.
I believe it's something more, have you noticed that the three dots in the right are also missing?

from retroarch.

OK. I went back to English and the entry also doesn't appear. It's something else not related with translations.

from retroarch.

In ArkOS, the entry is specifically removed to prevent resetting the configuration as if the user does this, the builtin controller no longer can control the interface. The patch used for this is here: https://github.com/christianhaitian/rk3566_core_builds/blob/master/patches/retroarch-patch-0003-disable_reset_and_enable_reboot_shutdown_menu_option.patch

from retroarch.

That indeed is not the proper way to hide the item. That only removes the action, but it should rather remove the display item in menu/menu_displaylist.c.

from retroarch.

I'm outside this conversation, but can I suggest keeping the menu entry, and having an optional retroarch.cfg.reset that is configured to the builtin controller.
Then that menu option is set, if this file exists, replaces the existing retroarch.cfg

from retroarch.

The specific line in menu_displaylist.c that should be commented out that removes the display would be helpful as I don't know where that it in looking at the code.

from retroarch.

I'll close this since the issue is sorted.

from retroarch.