Git Product home page Git Product logo

Comments (3)

Jamiras avatar Jamiras commented on July 22, 2024

READ_CORE_RAM and WRITE_CORE_RAM are tied to the RetroAchievements memory mapping scheme, and do seem to be working as expected if a game with achievements is loaded. For non-achievement related functionality, you should be using READ_CORE_MEMORY and WRITE_CORE_MEMORY.

RetroArch/command.h

Lines 437 to 444 in a7d5026

#if defined(HAVE_CHEEVOS)
/* These functions use achievement addresses and only work if a game with achievements is
* loaded. READ_CORE_MEMORY and WRITE_CORE_MEMORY are preferred and use system addresses. */
{ "READ_CORE_RAM", command_read_ram, "<address> <number of bytes>" },
{ "WRITE_CORE_RAM", command_write_ram, "<address> <byte1> <byte2> ..." },
#endif
{ "READ_CORE_MEMORY", command_read_memory, "<address> <number of bytes>" },
{ "WRITE_CORE_MEMORY",command_write_memory, "<address> <byte1> <byte2> ..." },

from retroarch.

beauxq avatar beauxq commented on July 22, 2024

READ_CORE_MEMORY and WRITE_CORE_MEMORY don't work with Sega Master System.
So I've been using the only thing I've found that does work.

Do you know how I can get READ_CORE_MEMORY and WRITE_CORE_MEMORY to work with Sega Master System?

from retroarch.

Jamiras avatar Jamiras commented on July 22, 2024

Because the default RetroAchievements addressing scheme is just SYSTEM_RAM followed by SAVE_RAM, READ_CORE_RAM works with both the retro_get_memory_data functions and the RETRO_ENVIRONMENT_SET_MEMORY_MAPS call.

READ_CORE_MEMORY requires the RETRO_ENVIRONMENT_SET_MEMORY_MAPS callback so it can map the addresses correctly. I'm guessing whichever core you're using doesn't implement RETRO_ENVIRONMENT_SET_MEMORY_MAPS.

from retroarch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.