gitdalisar / mod-faction-free Goto Github PK

Trial of the Crusader's items appear to be faction specific still.

Example item: 47808
--Item is a alliance specific mace, unable to be equipped by Horde

-Steps to replicate:
--Create horde level 80
--.additem 47808
--Attempt to equip

Error received is: "You can never use that item"

When the item drops in a raid, the faction that cannot equip the item will not see the loot roll chance either. The items dropping (alliance \ horde) appear to depend on who starts the fight via the NPC in the arena, this may aid in testing.

I believe there may be a faction flag in the items_template database preventing it?

Please let me know if I can post more \ help research.

Describe the bug
Buffing Alliance NPCs such as Stormwind Guards as a Horde player will act as if it is an attack (I.E., the spell will miss if you are on a low level character attempting it)

Steps To Reproduce
Steps to reproduce the behavior:

1. Go to Stormwind as Horde (or Orgrimmar as Alliance)
2. Find NPC Guard
3. Attempt to Buff
4. Get aggro

Additional Thoughts
Will need to see if this is fixed after the faction changes or if this is an outlier that will need to be addressed across the board.

Additional context
Initially reported by Ghost via DM on Discord.

Player hunter pets are attacking opposing faction players if the player gets PVP flagged and the pet is on aggressive.

Ex:

Player A is alliance warrior
Player H is horde hunter

Player A becomes PVP flagged from various means, Player H cannot attack the player manually. If Player H has his pet on aggressive, Player A will be attacked if in range.

I'm not sure .npc info of the pet is any use here, because we tested multiple pets (different factions\ids each time) and different characters. Let me know if you want other information \ what I can gather that could help narrow it down.

I believe we found two NPCs that will need faction fixed. They are faction specific to their respective quest, they may need moved to a neutral attackable one. These ones are not attackable and should be, they need killed and looted for a specific quest (Battered Hilt chain):

Horde Quest:
https://www.wowhead.com/wotlk/quest=24557/the-silver-covenants-scheme

Alliance Quest:
https://www.wowhead.com/wotlk/quest=14457/the-sunreaver-plan

NPCs are:
-36776 (Horde NPC killed by alliance)
-36774 (Alliance NPC killed by Horde)

Factions appear to be ID of 2027 (NPC 36774) and 2123 (NPC 36776) which is Silver Covenant and Sunreavers accordingly.

I am assuming these would need changed to an attackable neutral faction since those are likely too related to other quest givers.

See attached for full NPC info.

Describe the bug
Some items do have an allowablerace field that needs to be updated

Steps To Reproduce
Go to Honor Hold as a Horde and attempt to buy a griffin

Is your feature request related to a problem? Please describe.
Not related to a problem or bug, this is something again tied to the cross-faction settings in the worldserver.conf file. Will need to see if there is something either within .cpp files or maybe this is a UI .lua file change that needs to occur.

Describe the solution you'd like
Same functionality as if same faction, right-click a person's profile and have the option for "invite to group"

Describe alternatives you've considered
Nothing at this point. The only thing you can do is /invite command to get a person in or invite if in guild or friends list.

Additional context
Initially reported by Ghost vi DM on Discord.

Describe the bug
Attacked by PVP NPCs despite being friendly

Is your feature request related to a problem? Please describe.
No, this is not related to a problem. The method that cross-faction operates in Azerothcore is through the worldserver.conf settings. This appears to override the allowance of being in a group or raid together and then that allows for cross-faction features to appear.

Describe the solution you'd like
It would be good to have healing and buffing allowed for cross-faction play OUTSIDE of being in a group first to make those features work.

Describe alternatives you've considered
There are not really any workarounds to this due to the limitations in place for factional game play. Will likely need to modify .dbc files to get this to occur, if it is even possible. Will need to research exactly what flags could be set to make this possible.

Additional context
Initially reported by Ghost via DM in Discord.

Describe the bug
Ground effect damage (Consecrate) will sometimes damage NPCs of the opposing faction

Steps To Reproduce
Example scenario: Paladin Tome of Valor Quest (ID: 1651), laying consecrate next to the NPC you defend (NPC ID: 6182) will cause them to take damage and be hostile to you

Additional Thoughts
This again may be resolved with the faction changes that are being included in v1.4.1.0 of this module, but will need to verify.

Additional context
Initially reported by Ghost via DM on Discord.

Describe the bug
When in an opposing faction inn, you do not get the rested buff to generate rested XP

Steps To Reproduce
Go to opposing faction inn.

Additional context
Can still use services of the inn and bind hearthstone to the inn, just cannot gain rest XP while there.

Describe the bug:
Players will still automatically be flagged for PvP when entering cities of the opposing faction. For example, if you are Blood Elf and enter Stormwind City.

Steps To Reproduce:

1. Enter into a city of the opposing faction.
2. Notice that the player has automatically been flagged for PvP.

Screenshots:
Example after converting Stormwind to a Sanctuary:
https://imgur.com/a/M0skeMm

Suggested Resolution:
I was able to resolve this by converting the cities into a Sanctuary by modifying the AreaTable.dbc file. There may be other ways to resolve this, but I'm not sure how to directly say "Hey, don't enable the PvP flag automatically when I enter "x" area, but at least for me, converting it to a Sanctuary is a quick and easy way.

See below steps that I took for resolving this:

1. In game, go to the location you want to change to a Sanctuary and then type ".gps". Note down the Zone ID. My example of Stormwind City gave me a Zone ID of 1519.

2. Open AreaTable.dbc and find ID 1519 for Stormwind City.

3. Change the "Flags" column to one of the following numbers: 19496 (Sanctuary, no duels allowed), 19456 (Sanctuary, duels allowed). For my example, I ended up using 19496.

4. Save the AreaTable.dbc file and drop it into both your server Data/dbc path, as well as the .MPQ patch for the client.

While I am able to talk to the flight masters at each of the Alliance/Horde areas I am not able to access the flight path for the cross faction. Example: For some of the flight masters, not in the main cities, I am able to fly to any of the Horde locations that I have open but not any of the Alliance based ones. In the main cities (e.g. Stormwind, Iron Forge, etc.) I get the message "You don't know any flight paths connected to this one". For reference I have a Horde Tauren that I went into both Stormwind and Iron Forge to test the paths and talked to Alliance flight masters along the route.

Describe the bug
Cannot Read Cross faction Text

Steps To Reproduce
Some NPCs will talk gibberish that are opposite faction. I encountered this most often when using the new portal system. The goblin (Im a Draenei) will say "gfhghtntuj ntrnignt ntiing" when she encounters an issue but otherwise her text is readable.

Is your feature request related to a problem? Please describe.
Flightpaths can be "learned" from the opposing faction but then when you speak to the person, the flight paths do not show up and you cannot truly use them.

Describe the solution you'd like
It would be good to have the flightmasters all work as a single network.

Describe alternatives you've considered
The alternative right now is to leverage the teleport network that is part of this module. The issue with this request is that the bitmask for alliance and horde "known taxi nodes" is identical. Thus a bitmask of say 101 (not a real mask, just using for illustration) may give an Alliance player the ability to fly from Stormwind to Ironforage, the exact same bitmask of 101 will give a Horde player the ability to fly from Undercity to Sepulcher. So in order to resolve this you'd have to rework the entire taxinode bitmask system and have essentially 2 different masks, something like 1-1024 for Alliance and 1025-2048 for Horde, then the ability to have 3072 to have access to the full bitmask of both. Not sure what level of effort that would even take.

Additional context
Initially reported by Ghost via DM on Discord.

Is your feature request related to a problem? Please describe.
No, this is not related to a problem. The method that cross-faction operates in Azerothcore is through the worldserver.conf settings. This appears to override the allowance of being in a group or raid together and then that allows for cross-faction features to appear.

Describe the solution you'd like
It would be good to have the trading and buffing allowed for cross-faction play OUTSIDE of being in a group first to make those features work.

Describe alternatives you've considered
There are not really any workarounds to this due to the limitations in place for factional game play. Will likely need to modify .cpp files to get this to occur, if it is even possible. Will need to research exactly where those worldserver.conf settings get taken into consideration within the source code and then either modify or remove the checks for faction to allow this to occur.

Additional context
Initially reported by Ghost via DM in Discord.

High Overlord Saurfang is attacking alliance characters when entering the ICC raid:

https://www.wowhead.com/wotlk/npc=37187/high-overlord-saurfang

The later versions of him in the raid are not hostile \ attack, it is only this specific instance at the entrance: