Comments (2)
Comment about spells from Issue #8 :
Looking more into this, to cast spells on players of opposite faction outside of your group, this may cause a LOT of unintended behavior. Within the targets you can pick for a spell you do have TARGET_UNIT_TARGET_ALLY or TARGET_UNIT_TARGET_ENEMY typically for buffs/damage accordingly. There does NOT seem to be a TARGET_UNIT_TARGET_PLAYER so I think if we open up the ability to heal/buff/etc players outside the faction, it will result in also being able to accidently drop a heal on a boss mid fight... I'll look into it a bit more but do not think this one is going to be doable.
from mod-faction-free.
So I do think this is plausible but I still think there will be some conflicts and unintended behavior... It looks like it will need to be a combination of a few things:
- Need to find all spells and abilities that would be beneficial in nature (buff, heal, cure, revive, etc.) that are player castable since modifying the spells an NPC will cast or an item will cast may not be needed or wanted
- Will have to ensure both TARGET_UNIT_TARGET_ALLY and TARGET_UNIT_TARGET_ENEMY are both set as opposing faction members are considered "enemy" until in a group
- Need to set SPELL_ATTR3_ONLY_ON_PLAYER on AttributesExC to ensure the heals and such cannot land on enemy NPC to avoid accidently healing a boss mid fight or breaking the mechanic of casting a heal mid-fight and it automatically landing on you as monster is invalid target
Now for what this means:
- I think this will break any cases where a quest requires you to cast those spells on an NPC in order to progress a quest as you will now have a flag set that say "heal" can only be cast on a player (thinking the early quest for Priests and such)
- I think this will break spells like Penance where it has dual function of hitting an ally (heal) or enemy (damage) as an opposing faction player is still an "enemy"
Just not sure there is a clean way to do this.
from mod-faction-free.
Related Issues (18)
- Cross Faction Flight Paths HOT 6
- [BUG] Players still get flagged as PvP when entering opposing cities HOT 7
- [BUG] attacked by pvp npc HOT 7
- [BUG] Cannot Read Cross faction Text HOT 4
- [BUG] Cannot receive Rest XP while in opposing faction inn HOT 3
- [BUG] Some items are not purchasable due to faction HOT 4
- [FEATURE] - Add cross-faction trade/buffing outside of group HOT 3
- [BUG] Buffing Cross-Faction NPC results in aggro HOT 1
- [FEATURE] Add cross-faction players to group via nameplate menu options HOT 2
- [BUG] AOE damage triggers combat with otherwise neutral npc HOT 1
- [FEATURE] Allow for cross-factional flightmasters and hook the two networks together HOT 2
- [BUG] Unattackable Quest NPCs for Battered Hilt chain HOT 4
- [BUG] Player Hunter Pets attacking PVP flagged opposing faction HOT 3
- [BUG] ToGC items are faction specific HOT 1
- [BUG] High Overlord Saurfang attacking Alliance characters in ICC entrance HOT 1
- [BUG] PvP not possible in battlegrounds
- [BUG] NPCs that are not attackable and/or prevent quest completions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mod-faction-free.