phimp.me currently redirects to

https://github.com/fossasia?utf8=✓&query=phimpme

It doesn't work and should be changed to

https://github.com/fossasia?utf8=✓&q=phimpme

Hello,
I'm a student who participate google code in contest.
I would like to improve the user interface using material design.
Thank you.

App is crashing when setting parameters.

Error as below:

FAILURE: Build failed with an exception.

• What went wrong:
  A problem occurred configuring project ':app'.

  failed to find target with hash string 'Google Inc.:Google APIs:23' in: /usr/local/android-sdk

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
  BUILD FAILED

Add the jacoco plugin and required scripts to integrate with travis.

The app is crashing in tablet due to incorrect xmls:ads in main.xml(layout)

Expected Behaviour
xmlns:ads="http://schemas.android.com/apk/lib/com.google.ads"
should be replaced with
xmlns:app="http://schemas.android.com/apk/res-auto".
or
Comment adviews in main layout (large,small,x-large).

Steps to reproduce it

Try to run this app in the tablet (large- screen devices). Open mail.xm(layout-large,small,land,x-large).

LogCat for the issue

java.lang.RuntimeException: Unable to start activity ComponentInfo{vn.mbm.phimp.me/vn.mbm.phimp.me.PhimpMe}: android.view.InflateException: Binary XML file line #47: Error inflating class com.google.ads.AdView
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2260)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2325)
at android.app.ActivityThread.access$800(ActivityThread.java:145)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1216)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5266)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:826)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:642)
at dalvik.system.NativeStart.main(Native Method)
Caused by: android.view.InflateException: Binary XML file line #47: Error inflating class com.google.ads.AdView
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:711)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:759)
at android.view.LayoutInflater.inflate(LayoutInflater.java:496)
at android.view.LayoutInflater.inflate(LayoutInflater.java:398)
at android.view.LayoutInflater.inflate(LayoutInflater.java:353)
at android.support.v7.app.AppCompatDelegateImplV9.setContentView(AppCompatDelegateImplV9.java:284)
at android.support.v7.app.AppCompatActivity.setContentView(AppCompatActivity.java:143)
at vn.mbm.phimp.me.PhimpMe.onCreate(PhimpMe.java:216)
at android.app.Activity.performCreate(Activity.java:5277)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2213)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2325)
at android.app.ActivityThread.access$800(ActivityThread.java:145)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1216)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5266)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:826)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:642)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.ads.AdView" on path: DexPathList[[zip file "/data/app/vn.mbm.phimp.me-2.apk", zip file "/system/priv-app/AmazonPlatform-release.apk", zip file "/system/priv-app/DeviceClientPlatformContractsFramework.apk", zip file "/system/priv-app/DeviceSoftwareOTAContracts.apk", zip file "/system/priv-app/MetricsApi-2066310.apk", zip file "/system/priv-app/RemoteSettingsInternalSDK.apk", zip file "/system/priv-app/amazon.jackson-19.apk", zip file "/system/priv-app/com.amazon.communication.apk", zip file "/system/priv-app/com.amazon.dp.logger.apk"],nativeLibraryDirectories=[/data/app-lib/vn.mbm.phimp.me-2, /vendor/lib, /system/lib]]
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
at java.lang.ClassLoader.loadClass(ClassLoader.java:497)
at java.lang.ClassLoader.loadClass(ClassLoader.java:457)
at android.view.LayoutInflater.createView(LayoutInflater.java:563)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:700)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:759)
at android.view.LayoutInflater.inflate(LayoutInflater.java:496)
at android.view.LayoutInflater.inflate(LayoutInflater.java:398)
at android.view.LayoutInflater.inflate(LayoutInflater.java:353)
at android.support.v7.app.AppCompatDelegateImplV9.setContentView(AppCompatDelegateImplV9.java:284)
at android.support.v7.app.AppCompatActivity.setContentView(AppCompatActivity.java:143)
at vn.mbm.phimp.me.PhimpMe.onCreate(PhimpMe.java:216)
at android.app.Activity.performCreate(Activity.java:5277)

Would you like to work on the issue?

Yes.

Actual Behaviour

After selecting a photo from the gallery or taking a photo from the phone camera, the geolocation button does not do anything. The values of the latitude and longitude are -1. It does not change after clicking the button

Expected Behaviour

The values of latitude and longitude should change according to the user location.

Steps to reproduce it

1. Take user current location using locationListener.
2. Get the values of latitude and longitude.
3. Set the values of latitude and longitude.

Would you like to work on the issue?

Yes, I would love to do it. Can I proceed with it?

As stated in the features the home screen features would need enhancement:

• Show local captured images
• Grid view of images

There is security exception as per the crash report.

java.lang.SecurityException: Permission Denial: not allowed to send broadcast android.intent.action.MEDIA_MOUNTED from pid=8193, uid=10325
                                                                   at android.os.Parcel.readException(Parcel.java:1620)
                                                                   at android.os.Parcel.readException(Parcel.java:1573)
                                                                   at android.app.ActivityManagerProxy.broadcastIntent(ActivityManagerNative.java:3074)
                                                                   at android.app.ContextImpl.sendBroadcast(ContextImpl.java:777)
                                                                   at android.content.ContextWrapper.sendBroadcast(ContextWrapper.java:402)
                                                                   at vn.mbm.phimp.me.newGallery$DownloadImageAsyncTask.onPostExecute(newGallery.java:6951)
                                                                   at vn.mbm.phimp.me.newGallery$DownloadImageAsyncTask.onPostExecute(newGallery.java:6704)
                                                                   at android.os.AsyncTask.finish(AsyncTask.java:651)
                                                                   at android.os.AsyncTask.-wrap1(AsyncTask.java)
                                                                   at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:668)
                                                                   at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                   at android.os.Looper.loop(Looper.java:148)
                                                                   at android.app.ActivityThread.main(ActivityThread.java:5461)
                                                                   at java.lang.reflect.Method.invoke(Native Method)
                                                                   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                                                                   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
                                                                   at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:102)

Actual Behavior

If you press back button on settings, upload and camera it goes back to gallery and then close the app promptly and we have to select the options from navigation given below. There are some Spelling and Grammar error in dialog boxes.

Expected Behaviour

It should go back to home screen and shouldn't close app. It can be made swipe view that if screen is swiped left then it goes to camera option and if swiped again it goes to upload and so on

Steps to reproduce it

It might because of value which remain saved in key code it can be made right by making it to "0" after setting view to home screen.
Screen can be converted into swipe view by viewpager.

Would you like to work on the issue?

Yes I would like to work on these.

Please add relevant documentation to https://github.com/fossasia/phimpme-android/blob/master/README.md

Coming from this GCI 2016 task: https://codein.withgoogle.com/dashboard/task-instances/5984010633216000/

Hi, I'd like to revamp the UI to conform with Material Design guidelines.

A few questions:

• What is this app mainly designed to do? What's its main focus?
• Is there a minimum Android version I need to support? I'm not entirely sure, but some UX libraries for Material aren't compatible with older versions of Android

Thanks!

Actual Behaviour

The flash ⚡ icon oriented in a different direction when switching between;

• Flash ON
• Flash AUTO
• Flash OFF

Expected Behaviour

The flash ⚡ icon has to be relative to the phone orientation!

Steps to reproduce it

1. Open app and go to Camera view
2. Keep the phone in a vertical position and try switching Flash icon

LogCat for the issue

Not available

Screenshots of the issue

Would you like to work on the issue?

Yes 👍

Actual Behaviour

There is no fixed code practices.

Expected Behaviour

How about adding code practices like in other fossasia projects. eg https://github.com/fossasia/susi_android#code-practices

The app currently uses a dark theme, used in older versions of android can we go for a complete make over in design.

What test frameworks are useful apart from travis? Please propose and implement them.

Actual Behaviour

Open the image, press back button and opening another image crashes the app

Expected Behaviour

The app shouldn't crash after opening another image

Steps to reproduce it
Open the image, press back button and open another image (Repeat it as the behavior appears to be random, sometimes the crash happens while opening second image, sometimes third)

LogCat for the issue

03-05 00:13:23.059 9470-9470/vn.mbm.phimp.me E/AndroidRuntime: FATAL EXCEPTION: main
                                                               Process: vn.mbm.phimp.me, PID: 9470
                                                               java.lang.RuntimeException: Unable to resume activity {vn.mbm.phimp.me/vn.mbm.phimp.me.PhimpMe}: android.database.StaleDataException: Attempted to access a cursor after it has been closed.
                                                                   at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3028)
                                                                   at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3063)
                                                                   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1361)
                                                                   at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                   at android.os.Looper.loop(Looper.java:135)
                                                                   at android.app.ActivityThread.main(ActivityThread.java:5343)
                                                                   at java.lang.reflect.Method.invoke(Native Method)
                                                                   at java.lang.reflect.Method.invoke(Method.java:372)
                                                                   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:905)
                                                                   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:700)
                                                                Caused by: android.database.StaleDataException: Attempted to access a cursor after it has been closed.
                                                                   at android.database.BulkCursorToCursorAdaptor.throwIfCursorIsClosed(BulkCursorToCursorAdaptor.java:64)
                                                                   at android.database.BulkCursorToCursorAdaptor.requery(BulkCursorToCursorAdaptor.java:133)
                                                                   at android.database.CursorWrapper.requery(CursorWrapper.java:186)
                                                                   at android.app.Activity.performRestart(Activity.java:6062)
                                                                   at android.app.Activity.performResume(Activity.java:6088)
                                                                   at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3011)
                                                                   at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3063) 
                                                                   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1361) 
                                                                   at android.os.Handler.dispatchMessage(Handler.java:102) 
                                                                   at android.os.Looper.loop(Looper.java:135) 
                                                                   at android.app.ActivityThread.main(ActivityThread.java:5343) 
                                                                   at java.lang.reflect.Method.invoke(Native Method) 
                                                                   at java.lang.reflect.Method.invoke(Method.java:372) 
                                                                   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:905) 
                                                                   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:700) 

Would you like to work on the issue?

Yes

The goal of this issue is to get an apk on each merged pull request build in the apk branch.

Use travis to build apks automatically. You can check other FOSSASIA projects e.g. Open Event Android and Susi Android how it is done there.

Actual Behavior
When we press the discard button after taking a picture, the image still gets saved and shows up in gallery

Expected Behavior
Discard button should delete the saved copy

Steps to reproduce it

1. Take a picture.
2. discard it.
3. go to gallery tab, the image is still saved.

Would you like to work on the issue?

Yes, I would like to work on it.

Need to upgrade the maps library to v2 from current v1.
v2 will not use MapActivity so need to refactor the code.

on importing the project to android studio, project build fails with the following error message "Gradle sync failed: Failed to find target with hash string 'Google Inc.:Google APIs:23' in: C:\Users\user\AppData\Local\Android\Sdk".

changing the compileSdkVersion to 24 in build.gradle file in app folder does the work.

I can pr fr this ?

Adding instructions for contributors is a good way IMO. We can add things like guidelines for new contributors, tutorials on squashing, branching policy, commit message guidelines etc. What do you all say guys?

Travis doesnot check for runtime errors of the app currently, we could implement such a system with danger or maybe a bot account to post the previews of the app by taking screenshots or maybe a simple giff which shows the transition of screens and demonstrates button and function clicks as a comment to a PR via Travis or other CI, this could improve the testing, would result in an increase in overall app quality and there would be new contributors for sure. But it's a bit difficult.

This is how I suggest a method (I couldn't give a flowchart so I am expressing it as steps):

1. User makes a PR (Already there)
2. Github calls Travis via git hook (Already being done)
3. Travis generates app (Already being done)
4. Travis runs espresso tests (Not being done)
5. After each espresso test we call in a function from a class which would be put into the tests folder, generating screenshots and saving them. (Not being done)
6. Another script would make a comment with this image or we could pass them to danger and danger makes a comment with them on the PR.

What are your opinions?

Actual Behaviour

1- If you upload any image from upload activity it only add one picture and doesn't add more than one pictures to list view.
2- If you add pictures from floating upload button it corrupts first entry in list view of your uploaded list.
3- If you add pictures from floating upload button from gallery it doesn't prompt you on entering same picture again and again.

Expected Behaviour
1- It should add selected image into an list instead of only single image.
2- It should add image to uploaded list continuing from the last image in the list.
3- I should ask user if user wants to enter same picture again as it is already in upload list.

Steps to reproduce it

It can be done by checking errors in making list of images and showing them in list view.

Would you like to work on the issue?

Yes I would Like to work on these.

App has been stopped

When i select an image from gallery fragment ....
if image scale size is too large it has been crashed when image scale size is small it has no problem

we need to remove this issue. User can also upload large scale images and edit it and copped.

When i want to add imagw for edit or upload. App has been stopped

In Phimp, taking pictures from the camera results in duplicating the image. As I have observed, the image is saved in two different folders with two different names!

1. take_photo
2. PhimpMe_Photo_Effect

Hence when the images from the external storage is fetched, it will show the same image twice.

Steps to re-produce

• Open App and go to Camera
• Click on Camera icon and take a picture
• Click Save

Now go to Upload and click on the + icon to load the image gallery and you will see duplicates

Also note that if I don't click Save and click Discard, the camera will be open again. And if we go back, then only one image will appear in the gallery.

• Duplicates shown in new Gallery GridView
  

• Duplicates shown in Upload
  

• Duplicates don't occur if we discard and click back from the Camera view
  

Please add an automatically generated apk with travis into the repository.

Error:Failed to find target with hash string 'Google Inc.:Google APIs:23' in:
Open Android SDK Manager

Solve the issue
compileSdkVersion 23 instead of compileSdkVersion 'Google Inc.:Google APIs:23'

Although the project is using libraries of earlier versions, the compile SDK version and the versions of the appcompat and design libraries used should be updated to make it compatible with Nougat Devices.

Due to deprecation of few things in the code base it has become tedious to work on it (majorly map related v1 is depreciated).

Even if I try to make changes there will be possibilities that they will cause conflicts. It would be great if we could come up with a solution so it becomes easier for people to set up the project in the Android Studio environment and test.

The possible solution to change the map related code is to remove them to make the other code testable and write them again in v2.

What are the features of this app? Please add a list to the Readme.md

Edit, Upload and Share options are not working when open image from gallery.

Actual Behaviour

Dependencies are not being cached and are downloaded again and again, Travis doesnot have that much internet speed!

Expected Behaviour

Gradle dependencies should be cached.

Steps to reproduce it

See the Travis CI log

Would you like to work on the issue?

No. Someone else could try.

Improving the overall UI of the app. Adding style file to incorporate material design and update the aesthetic.

Adding PRs and issue templates would make the project more better, we could make use of the default .github folder to do so. Can we have it?

We don't have tests currently. Checking that each function works correctly is an integral part in an app development and tests should be used. Currently the project doesnot have any tests and as indicated by codecov the code coverage is currently 0%.While we build the app on Travis and test the changes, it won't be enough, we need to start writing tests.

As a starting point, write junit tests for:

• ACRAReport.java
• AddAccountDialogFragment.java
• BluetoothShareMultipleFile.java
• CacheStore.java
• CollectUserData.java

This should be done after all features start working as they have more priority than this

Actual Behaviour

No tests are defined for testing the UI of the application

Expected Behaviour

Espresso Testing should be implemented to check for the UI elements.

Would you like to work on the issue?

Yes

#60 after this merge the app is trying to load all the photos in my phone and its tuck after the splash screen. I have over 5000 images in my phone.
The log is
I/CACHE: Saved file /storage/emulated/0/WhatsApp/Media/WhatsApp Images/IMG-20160918-WA0012.jpeg (which is now /storage/emulated/0/.PhimpMeCache/040317015410104.png) correctly for each photo.
I think the previous method was good to show only 6 images at once and then load more on button click.
@pa1pal please check.

Actual Behavior
Currently, the app allows photos to be shared explicitly via Bluetooth.

Expected Behavior
We can extend it to a 1 click share button that allows sharing via any app that allows Image content.

Would you like to work on the issue?

Yes, I would like to work on it.

We need to update Google Maps API and code according to it. Facing issues when trying to build gradle due to it.

Actual Behaviour

Currently the user has to scroll all the way down to the particular pictures and it becomes tough to find the picture he/she wishes to upload from a sea of pictures.

Expected Behaviour
A choose folder functionality will allow the user to choose from different folders on his/her device making the task much easier.

Would you like to work on the issue?

Yes,i would definitely like to work on the issue.

Actual Behaviour

Currently when the user tries to switch the camera, there is always an app crash as Camera API is depreciated

Expected Behaviour

There should be no such crashes and depreciated code should be changed with new cameraV2 api.

Steps to reproduce it

Open app , go to camera , press the camera switch button.

Would you like to work on the issue?

Yes.

Can't able to signin after selecting facebook account from the list.

The current implementation of wordpress works only for older versions. Because of plugins gets deprecated. New version are not supported.

Travis credentials for the repo is needed to push the generated apk to the apk branch, since they are not available to pull requests, we could run these scripts on direct commits, since github addresses PR merge commits like direct commit, we can safely have the apk generated for PR merges.

This issue is very easy and can be solved by a one line solution with the help of a Travis variable.

This would improve the build time for PR, as Travis currently tries to push after cloning the repo and it can't push and there is no need to do so!

Most of the features in settings activity are not working.
On click app crashed.

App crashes while opening in Marshmallow above devices. Needs to get Runtime permission for READ_EXTERNAL_STORAGE.

java.lang.RuntimeException: Unable to resume activity {vn.mbm.phimp.me/vn.mbm.phimp.me.PhimpMe}: java.lang.SecurityException: Permission Denial: reading com.android.providers.media.MediaProvider uri content://media/external/images/thumbnails from pid=26836, uid=10126 requires android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
                                                                     at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3121)
                                                                     at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3152)
                                                                     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2495)
                                                                     at android.app.ActivityThread.-wrap11(ActivityThread.java)
                                                                     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1354)
                                                                     at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                     at android.os.Looper.loop(Looper.java:148)
                                                                     at android.app.ActivityThread.main(ActivityThread.java:5443)
                                                                     at java.lang.reflect.Method.invoke(Native Method)
                                                                     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
                                                                     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
                                                                  Caused by: java.lang.SecurityException: Permission Denial: reading com.android.providers.media.MediaProvider uri content://media/external/images/thumbnails from pid=26836, uid=10126 requires android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
                                                                     at android.os.Parcel.readException(Parcel.java:1620)
                                                                     at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:183)
                                                                     at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:135)
                                                                     at android.content.ContentProviderProxy.query(ContentProviderNative.java:421)
                                                                     at android.content.ContentResolver.query(ContentResolver.java:491)
                                                                     at android.content.ContentResolver.query(ContentResolver.java:434)
                                                                     at vn.mbm.phimp.me.newGallery.resumeLocalPhoto(newGallery.java:3407)
                                                                     at vn.mbm.phimp.me.newGallery.onResume(newGallery.java:3242)

No DRP key due to exception:java.lang.ClassNotFoundException: com.android.webview.chromium.Drp

The idea is to replace the icons by following the Material Design guidelines, especially the ones in the take picture activity and the editing activity, plus to fix some bugs related to them.

Actual Behaviour

When a commit is made on a fork, slack gets notification.

Expected Behaviour

Notification should not be made.

Would you like to work on the issue?

Yes.