Git Product home page Git Product logo

Comments (11)

heysadboy avatar heysadboy commented on July 16, 2024

Yeah, I think it is a great idea.

  • Create an issue about the pull request you are going to send. Attach screenshots and some information wherever possible so that the reference to the pull request can be made.
  • There is depreciated code in the repository, avoid deleting any comments.
  • Although it has been stated implicitly other times, please send pull to the development branch for now.
  • Send one fix per pull request. Similarly, send all the commits for one fix in a single pull request.
  • Have substantiate amount of discussion with the maintainers of the repository to avoid conflicts.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

Yes it is good for all. I think creating Wiki would be best for this.

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@pa1pal Should I make one?

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

Well wiki's should describe the project while the contributors guide guides the contributors @heysadboy feel free to do so.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

@heysadboy Wiki are not enabled yet in the project. So I requested to owner to change settings. I will notify you when it is up.

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

Well can't we have both? Wiki and the contributors guide in the CONTRIBUTING.md it pops up when you make an issue or a PR

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

I see @pa1pal, thanks.

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

@heysadboy @pa1pal Mario sir has rejected the proposal for the wiki pages, so we need to go on with the contributing.md file.

I have another query for you guys, should we implement good commit message policy? --- This would improve the commit standard and the repo standard.

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@Abhi2424shek I think it is necessary, we should go for it.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

Yes we need to add contributing.md file now.
For the commit message. We can follow the basic guidelines which other fossasia projects follow. Like Open-event android.

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@pa1pal Okay I will send the pull request in a while.

from phimpme-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.