Git Product home page Git Product logo

Comments (22)

pa1pal avatar pa1pal commented on July 16, 2024 1

@heysadboy Yes. Go ahead.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024 1

You can use this guide to implement the runtime permissions in android the correct way.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024 1

issue2

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@pa1pal Can I work on this issue?

from phimpme-android.

dynamitechetan avatar dynamitechetan commented on July 16, 2024

Actually I fixed this. When I was writing code for camera PERMISSION, I asked storage and location permissions too.
Please Check the PR.

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@dynamitechetan Thanks. Please do inform in advance from next time if you work on a bug collectively to avoid clashes.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

@dynamitechetan Yes you did permissions part in your PR, good job.
But app in crashing on newGallery.java for Read external storage permission. It needs to be done there as well. Look at the stack trace for more info.

from phimpme-android.

dynamitechetan avatar dynamitechetan commented on July 16, 2024

@pa1pal I wrote the permission check in the Phipme activity. I tried a fresh install on my friends phone it's not crashing.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

@dynamitechetan on which android version? Its crashing on my Marshmallow device.

from phimpme-android.

dynamitechetan avatar dynamitechetan commented on July 16, 2024

Marshamallow and Nougat.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

It is strange. Wait.

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@pa1pal It is crashing on marshmallow. I checked.

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

@heysadboy @dynamitechetan implemented runtimepermissions using this library. It ask for permissions later, but first crash with the above log.

from phimpme-android.

dynamitechetan avatar dynamitechetan commented on July 16, 2024

Okay. Trying to fix this.

from phimpme-android.

optnio00 avatar optnio00 commented on July 16, 2024

i think you should use 25.0.1+ build toolds.
edit this in gradle files

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

The build tools are 25.0.2 @optnio00

from phimpme-android.

optnio00 avatar optnio00 commented on July 16, 2024

ok
Then open Android terminal in android studio and see what is the error and then ask again or google that error

from phimpme-android.

heysadboy avatar heysadboy commented on July 16, 2024

@optnio00 The error arises due to the updated google guidelines to explicitly accept the permissions from user. It would be great if you could attach screenshots so we know more. The build tools are 25.0.2, please see if you are working on development branch.

from phimpme-android.

dynamitechetan avatar dynamitechetan commented on July 16, 2024

No this error was due in onResume method of NewGallery.java
Actually this was being called before I checked for permissions.
I wrote a check for that now.

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

Which PR @dynamitechetan ?

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

@pa1pal isn't this solved?

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

@Abhi2424shek it wasn't fixed in #52.
#64 did the fix.

from phimpme-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.