Git Product home page Git Product logo

Comments (8)

ronaksakhuja avatar ronaksakhuja commented on July 16, 2024 1

Will start working on it @pa1pal .

from phimpme-android.

ronaksakhuja avatar ronaksakhuja commented on July 16, 2024

On it :)

from phimpme-android.

CloudyPadmal avatar CloudyPadmal commented on July 16, 2024

Hello @ronaksakhuja !! You can work on it! But shall we wait a little till @pa1pal or @Abhi2424shek give a comment on this one? I feel like since that Save is for the edited image, they're keeping the original and the edit on purpose 🤔

from phimpme-android.

ronaksakhuja avatar ronaksakhuja commented on July 16, 2024

@CloudyPadmal Alright .

from phimpme-android.

abishekvashok avatar abishekvashok commented on July 16, 2024

Ok, got an opinion for you guys to consider.
If this is intentionally a feature to edit images. Here is my opinion:

  • Images should not be saved twice if no changes are made when editing.
  • There must be an option in settings to turn editing after taking a photo on or off.
  • The image editing activity should have a title stating to edit the image.

If it was not intentionally a feature to save images twice, i.e, it is a bug then my opinion is to:

  • Remove the feature

I feel this was intentionally a feature but can't conclude without @pa1pal commenting his opinion!

from phimpme-android.

CloudyPadmal avatar CloudyPadmal commented on July 16, 2024

Agreed @Abhi2424shek !!

Or may be an implementation can be suggested to show the preview of the image and have some buttons and menus there to save or edit and save or discard the image!!

Once it is confirmed @ronaksakhuja can take it :)

from phimpme-android.

ronaksakhuja avatar ronaksakhuja commented on July 16, 2024

Agreed @Abhi2424shek .
We shall wait for @pa1pal .

from phimpme-android.

pa1pal avatar pa1pal commented on July 16, 2024

agree with @Abhi2424shek. Firstly, we can work on fixing the bug of is saving images twice even when no editing done.
Then settings option suggested by Abhishek is nice. Use sharedpref with checkbox of toggle Button for user preference.

from phimpme-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.