Comments (8)
Will start working on it @pa1pal .
from phimpme-android.
On it :)
from phimpme-android.
Hello @ronaksakhuja !! You can work on it! But shall we wait a little till @pa1pal or @Abhi2424shek give a comment on this one? I feel like since that Save is for the edited image, they're keeping the original and the edit on purpose
from phimpme-android.
@CloudyPadmal Alright .
from phimpme-android.
Ok, got an opinion for you guys to consider.
If this is intentionally a feature to edit images. Here is my opinion:
- Images should not be saved twice if no changes are made when editing.
- There must be an option in settings to turn editing after taking a photo on or off.
- The image editing activity should have a title stating to edit the image.
If it was not intentionally a feature to save images twice, i.e, it is a bug then my opinion is to:
- Remove the feature
I feel this was intentionally a feature but can't conclude without @pa1pal commenting his opinion!
from phimpme-android.
Agreed @Abhi2424shek !!
Or may be an implementation can be suggested to show the preview of the image and have some buttons and menus there to save or edit and save or discard the image!!
Once it is confirmed @ronaksakhuja can take it :)
from phimpme-android.
Agreed @Abhi2424shek .
We shall wait for @pa1pal .
from phimpme-android.
agree with @Abhi2424shek. Firstly, we can work on fixing the bug of is saving images twice even when no editing done.
Then settings option suggested by Abhishek is nice. Use sharedpref with checkbox of toggle Button for user preference.
from phimpme-android.
Related Issues (20)
- Update uCrop to 2.x HOT 4
- Error Showing when we go for gradle project sync in the android studio aap dependicy HOT 2
- Problem in scrolling accounts/elements in "Accounts" tab in small screen mobile phones HOT 5
- Account Activity's RecyclerView.OnItemTouchListener not working HOT 3
- Error while building the project: Grade Sync Failed HOT 3
- Request: Option to disable splash screen HOT 7
- Crash HOT 7
- Error while building the project: Evaluating the project
- Not work on poco f1 HOT 3
- Share image to other platforms feature not working HOT 1
- Theme is not Working HOT 1
- There is no Filter Option HOT 1
- Failed to Build Project HOT 1
- Black screen when clicking the edit button on any picture HOT 2
- Use image processing features as if it were a library? HOT 2
- Failed to build HOT 1
- Google Play version does not open HOT 1
- Code quality image got not found and app site not found
- Some readme issues
- found a bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phimpme-android.