Git Product home page Git Product logo

Comments (7)

clintval avatar clintval commented on September 26, 2024

Looks reasonable to me! We could update what is considered a valid index to include the union of characters Illumina and 10x allow here:

sample-sheet/sample_sheet/__init__.py

Line 275 in 8da5c6b

_valid_index_value_pattern = re.compile(r'^[ACGTN]*$')

I probably won't have time to get to in the next few days FYI but it's now on my radar.

from sample-sheet.

golharam avatar golharam commented on September 26, 2024

from sample-sheet.

clintval avatar clintval commented on September 26, 2024

Thank you for the patch, and the unit test! I just published sample_sheet==0.10.0 with this feature. Please pip install! Bioconda will find the change automatically in the next few days.

from sample-sheet.

clintval avatar clintval commented on September 26, 2024

I'm migrating to an official public API freeze in 1.0.0. The API may change slightly, but function should remain the same.

Any feature requests, critiques of the API, and criticisms welcome before I commit. Thanks!

from sample-sheet.

golharam avatar golharam commented on September 26, 2024

I just pushed a final change as I missed an index set in the first PR. I wonder if an option to bypass index checking would be good for a future release.

from sample-sheet.

clintval avatar clintval commented on September 26, 2024

Thanks for the idea! Noted!

from sample-sheet.

clintval avatar clintval commented on September 26, 2024

Just published 0.11.0 to PyPi, Bioconda should follow after some period of lag.

from sample-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.