Git Product home page Git Product logo

Comments (12)

jmercouris avatar jmercouris commented on May 25, 2024 1

it can be done, depends on what Thomas thinks!

from nyxt.

jmercouris avatar jmercouris commented on May 25, 2024

@lansingthomas what say ye?

from nyxt.

lansingthomas avatar lansingthomas commented on May 25, 2024

Good idea.
Consistency is good for users.

Let's change the color of the buttons to reflect interaction state as as well.
Backward (not-clickable)
backward-history-1

  • surface: primary
  • text contrast-text

Backward (clickable)
backward-history

  • surface: action
  • text contrast-text

Forward (not clickable)
Forward-history-1

  • surface: primary
  • text contrast-text

Forward (clickable)
Forward-history

  • surface: action
  • text contrast-text

from nyxt.

lansingthomas avatar lansingthomas commented on May 25, 2024

Dark theme:
backward: (not-clickable)
backward-history-1

backward (clickable)
backward-history

Forward (not-clickable)
Forward-history-1

Forward (clickable)
Forward-history

from nyxt.

lansingthomas avatar lansingthomas commented on May 25, 2024

I want that nice blue to guide our new nyxters down the path :D

from nyxt.

jmercouris avatar jmercouris commented on May 25, 2024

I shall prrrrrovide.

from nyxt.

lansingthomas avatar lansingthomas commented on May 25, 2024

@jmercouris while you are in there, would you please make it so that left and right arrow keys change the pages appropriately in the quick-start

from nyxt.

aadcg avatar aadcg commented on May 25, 2024

@jmercouris while you are in there, would you please make it so that left and right arrow keys change the pages appropriately in the quick-start

What's not working with respect to the arrows in the quick-start?

from nyxt.

jmercouris avatar jmercouris commented on May 25, 2024

I believe Thomas means the keyboard arrows.

from nyxt.

aadcg avatar aadcg commented on May 25, 2024

@jmercouris, I see - binding keys in panel buffers. I think we lack the technical foundations to do that without a half-baked hack since we don't have the concept of focus in panel buffers.


@lansingthomas notice that in the proposed spec, the contrast between background and foreground is poor for all clickable elements. For instance, the contrast between #37a8e4 and #ffffff is less than 3. Given that these elements are extremely small, I would advice against it. The color that contrasts with #37a8e4 is black, not white.

from nyxt.

lansingthomas avatar lansingthomas commented on May 25, 2024

Yeah good point Andre.

@jmercouris can you pretty please try these combos for the clickable-arrow-panel-buffer-buttons:

light theme default state: action (#37A8E4) for the surface color and text+ (#000000) for the arrow icons.
light theme hovered state: action+ (#72CDFE) for the surface color and text+ (#000000) for the arrow icons.

dark theme (amphora) default state: action (#4C21AB) for the surface color and text+ (#FFFFFF) for the arrow icons.
dark theme (amphora) hovered state: action+ (#571FD2) for the surface color and text+ (#FFFFFF) for the arrow icons.

from nyxt.

aadcg avatar aadcg commented on May 25, 2024

@lansingthomas pro tip: if you surround hex colors in between ticks (`...`), the color is displayed.

Example: #37a8e4 (`#37a8e4`)

from nyxt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.