Git Product home page Git Product logo

Comments (13)

aadcg avatar aadcg commented on September 25, 2024 1

Good proposal! I'd suggest that the hovering effect on the prompt buffer source bar (where the arrow buttons are located) should match the behavior of the status buffer.

Maybe the icons should match the styling too - what about rotated versions of the arrows on the status buffer?

from nyxt.

aartaka avatar aartaka commented on September 25, 2024 1

De-assigning myself: I moved back to libs.

from nyxt.

aadcg avatar aadcg commented on September 25, 2024 1

I'm not working on this and won't do it in the future. My comment above was simply a wild suggestion.

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024 1

I'm not working on this and won't do it in the future. #3139 (comment) was simply a wild suggestion.

Yee haw 🐎 🌵 🤠

This Issue is really about matching style changes with state changes.

Lets not make status buffer / quick-start changes at the moment

@hgluka Let's see if Luka can get it done.

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

@aadcg good ideas

experimentation required.
Here are my thoughts up front. Ill try to post some mockups in a while.

...hovering effect on the prompt buffer source bar (where the arrow buttons are located) should match the behavior of the status buffer.

Hhmm, yeah principally I think this is a good idea. The difference is that the prompt source bar arrows should be infrequently used compared to the buttons in the status-buffer-bar. Maybe it is better if they are not grouped together, to show that they are not precisely related to the same tasks.

I want the arrows to flicker a tiny amount as people use the keyboard controls to paginate sources (to show what they do, and communicate position in the stack of suggestions).

Sooo.... for the arrows; matching the background highlighting behavior from the status-buffer-bar on a hover state, seems sensible. But when users are just paginating around the sources, we don't want the arrow backgrounds lighting up like a rave.

Maybe the icons should match the styling too - what about rotated versions of the arrows on the status buffer?

I'll try it and report back.

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

Seems fine:

Screenshot 2023-09-01 at 3 24 37 PM

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

svgs
down-chevron
up-chevron

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

#555555 for when arrows are grey

from nyxt.

aadcg avatar aadcg commented on September 25, 2024

@lansingthomas what if we used rotated versions of ^ (the SVG you propose in your post above) everywhere: status buffer for history-backwards/forwards, quick-start and in the context of this issue?

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

Here are some images for that @aadcg

closeup:
Group 112 (1)

Then the Quick start would look like:
Frame 10

The closed prompt buffer:
prompt buffer (closed) component

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

generally
I do NOT think they need to match in all three places

specifically
I like the open triangle for:

  • quick-start
  • source pagination

I like the closed triangle for status bar history-forwards/backwards

I also notice that there is a color issue with the background of the quick-start panel #eeeeee#ededed

@aadcg lets talk 1-1 man! I haven't caught you in a while, and we can make this easy decision about the icons together. (moving to email for scheduling)

from nyxt.

aadcg avatar aadcg commented on September 25, 2024

I do NOT think they need to match in all three places

Sure, can't argue with that!

from nyxt.

lansingthomas avatar lansingthomas commented on September 25, 2024

Describe your proposed change:
Three things:

  • change the arrows to the ones above
  • Mute the color of the arrows when next-source or previous-source is not available. (top of list, bottom of list,...)
  • Update the hover text for each → Next source (Shift-down) Previous source (Shift-up)

from nyxt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.