Comments (13)
Good proposal! I'd suggest that the hovering effect on the prompt buffer source bar (where the arrow buttons are located) should match the behavior of the status buffer.
Maybe the icons should match the styling too - what about rotated versions of the arrows on the status buffer?
from nyxt.
De-assigning myself: I moved back to libs.
from nyxt.
I'm not working on this and won't do it in the future. My comment above was simply a wild suggestion.
from nyxt.
I'm not working on this and won't do it in the future. #3139 (comment) was simply a wild suggestion.
Yee haw 🐎 🌵 🤠
This Issue is really about matching style changes with state changes.
Lets not make status buffer
/ quick-start
changes at the moment
@hgluka Let's see if Luka can get it done.
from nyxt.
@aadcg good ideas
experimentation required.
Here are my thoughts up front. Ill try to post some mockups in a while.
...hovering effect on the prompt buffer source bar (where the arrow buttons are located) should match the behavior of the status buffer.
Hhmm, yeah principally I think this is a good idea. The difference is that the prompt source bar
arrows should be infrequently used compared to the buttons in the status-buffer-bar
. Maybe it is better if they are not grouped together, to show that they are not precisely related to the same tasks.
I want the arrows to flicker a tiny amount as people use the keyboard controls to paginate sources (to show what they do, and communicate position in the stack of suggestions).
Sooo.... for the arrows; matching the background highlighting behavior from the status-buffer-bar
on a hover state, seems sensible. But when users are just paginating around the sources, we don't want the arrow backgrounds lighting up like a rave.
Maybe the icons should match the styling too - what about rotated versions of the arrows on the status buffer?
I'll try it and report back.
from nyxt.
Seems fine:
from nyxt.
from nyxt.
#555555
for when arrows are grey
from nyxt.
@lansingthomas what if we used rotated versions of ^
(the SVG you propose in your post above) everywhere: status buffer for history-backwards/forwards
, quick-start
and in the context of this issue?
from nyxt.
Here are some images for that @aadcg
Then the Quick start would look like:
from nyxt.
generally
I do NOT think they need to match in all three places
specifically
I like the open triangle for:
- quick-start
- source pagination
I like the closed triangle for status bar history-forwards/backwards
I also notice that there is a color issue with the background of the quick-start panel #eeeeee
→ #ededed
@aadcg lets talk 1-1 man! I haven't caught you in a while, and we can make this easy decision about the icons together. (moving to email for scheduling)
from nyxt.
I do NOT think they need to match in all three places
Sure, can't argue with that!
from nyxt.
Describe your proposed change:
Three things:
- change the arrows to the ones above
- Mute the color of the arrows when next-source or previous-source is not available. (top of list, bottom of list,...)
- Update the hover text for each →
Next source (Shift-down)
Previous source (Shift-up)
from nyxt.
Related Issues (20)
- Split screen rendering glitch HOT 1
- Url not shown for snippet annotation HOT 1
- Escaping prompted annotations crashes Nyxt HOT 2
- Nyxt fails to copy links on webpage HOT 3
- Refactor `nyxt/renderer/gtk:modifier-translator`
- Choppy scrolling on webpage HOT 1
- Delete `failsafe` start option
- Minibuffer does not change size HOT 1
- Nyxt does not accept URLs from system HOT 1
- Repeating Crash on Page Load HOT 4
- Browser does not recognize locales other than 'C' HOT 1
- Window title not properly set
- Reimplement multi window logic HOT 2
- Recover incognito browsing HOT 1
- Jump-to-heading should place index at nearest heading HOT 1
- `switch-to-buffer` should not start on the current buffer
- Reimplement `ffi-window-active`
- Delete `panel-buffer` logic
- More extensible theme/style system HOT 1
- White window when opening any website HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nyxt.