Git Product home page Git Product logo

Comments (3)

aadcg avatar aadcg commented on June 23, 2024 1

EDIT: @aadcg would fixing that count as a breaking change? It could maybe break user configs, I think.

I would say that it's a bug fix, not a breaking change. We don't advertise multiple define-configuration over the same parameter as far as I know. But I'd listen to @jmercouris here too.

from nyxt.

aadcg avatar aadcg commented on June 23, 2024

It could be a limitation of define-configuration.

Just for the sake of clarity, @hgluka, invoking C-n runs the command make-window.

from nyxt.

hgluka avatar hgluka commented on June 23, 2024

Yeah, I ran into a similar issue in #3120 (for the new extend-configuration, not define-configuration specifically).

define-configuration works by adding hook handlers for customization. The only problem is that they are executed in reverse order (from last to first).

EDIT: @aadcg would fixing that count as a breaking change? It could maybe break user configs, I think.

from nyxt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.