Comments (5)
You should always open an issue and assign it to yourself in that case. That communicates to your team members on what you're focusing.
from nyxt.
Both
dark-mode
from the toggle modes menu and theUse Dark Theme
button in the Common Settings section are causing an error -- and not initiating dark theme.
As far as I know, those two are unrelated.
dark-mode
runs thedarken
bookmarklet frombookmarklets-mode
, which just invokes a piece of JS code to darken a webpage.- Dark theme is the Nyxt theme, which handles the UI elements (and internal pages, panel and prompt buffers), but not the webpages themselves.
I can reproduce the error for dark-mode
and I think there's an easy fix.
Dark theme works for me, but I have to restart Nyxt for it to be applied. This will hopefully be fixed soon in #3120.
from nyxt.
@hgluka correct! Could you please close this issue and open a short issue mentioning the issue relative to dark-mode
?
The issue relative to the dark theme is implicit in #2296.
from nyxt.
@aadcg I was going to just make a PR with the fix, but I can open a new issue as well.
from nyxt.
Closing in favor of #3128.
from nyxt.
Related Issues (20)
- Cut on CL dependencies HOT 1
- secondary keybinding not displaying in internal page *help-bindings* HOT 1
- Website partially obscured when zoom factor is higher than 1 HOT 4
- `repeat-mode` broken
- Some slots are methods in disguise and `funcall*`
- Simplify `theme` library
- Replace `iolib` by SBCL's primitives
- Idle inhibition when watching videos HOT 3
- Replace `extended-command-source` by separate command akin to `eval-expression` HOT 2
- `binding`, `keybinding` and `keyboard-shortcut`
- Methods defined within `define-ffi-generic` shouldn't inherit from `t`
- Delete `override-map` logic
- Google SSO for Websites HOT 2
- Cannot Load Invader Extension HOT 3
- Odd OOP idiom (parent/child relationship)
- `ffi` focus methods
- Delete `ffi-buffer-make` and `ffi-window-make`
- `ffi-buffer-cookie-policy` and Electron
- Simplify URL display logic
- Fix `global-history` test HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nyxt.