Missing replay info about sc2replay-csharp HOT 4 CLOSED

Both of these can be calculated from the event logs, at least the amount I've parsed so far.

1. Read the timestamp on the last events. That would be the match length.

2. There should be example code in the test application. Here's the CalculateAPM function, which calculates a relatively-correct APM, even though it may not match exactly to SC2Gears or SC2. It's tough to say which events they do and don't count towards APM.

   private static void CalculateAPM(Replay replay)
   {
       var events = replay.PlayerEvents;
   
       if (events == null)
       {
           // This is experimental. With older replays, it appears to return a close approximation.
           return;
       }
   
       var eventGroups = events.Where(r => r.Player != null)
                               .Where(r => r.EventType != GameEventType.Inactive)
                               .GroupBy((r) => r.Player);
   
       foreach (var group in eventGroups)
       {
           var order = group.OrderBy((r) => r.Time);
           var last = order.Last();
           var count = group.Count();
   
           // Calculates APM per second.
           var apm = count / last.Time.TimeSpan.TotalSeconds;
   
           apm *= 60;
   
           Debug.WriteLine(last.Player.Name + "'s APM: " + apm);
       }
   }
   

from sc2replay-csharp.

Hi,

I tried the calculateAPM function. It seems always return the first player's APM. Am I missing something? Could you please help?

Thank you,

    private string CalculateAPM(Replay replay)
    {
        string str = "";
        var events = replay.PlayerEvents;

        if (events == null)
        {
            // This is experimental. With older replays, it appears to return a close approximation.
            return str;
        }

        var eventGroups = events.Where(r => r.Player != null)
                                .Where(r => r.EventType != GameEventType.Inactive)
                                .GroupBy((r) => r.Player);

        foreach (var group in eventGroups)
        {
            var order = group.OrderBy((r) => r.Time);
            var last = order.Last();
            var count = group.Count();

            // Calculates APM per second.
            double lastTimeSpan = last.Time.TimeSpan.TotalSeconds;
            var apm = count / lastTimeSpan;

            apm *= 60;

            str += (last.Player.Name + "'s APM: " + apm + "; match length: " + lastTimeSpan) + "<br>";
        }

        return str;
    }

    public ActionResult Index()
    {

        string baseUrl = Request.PhysicalPath + @"\Content\replays\replay4.SC2replay";
        Replay replay = Replay.Parse(baseUrl);

        ViewBag.Map = replay.Map;
        ViewBag.Player = replay.Players;

        ViewBag.GameType = replay.GameType;
        ViewBag.TeamSize = replay.TeamSize;
        ViewBag.ChatMessages = replay.ChatMessages;
        ViewBag.GameSpeed = replay.GameSpeed;
        ViewBag.PlayerEvents = replay.PlayerEvents;
        ViewBag.Gateway = replay.Gateway;
        ViewBag.ReplayBuild = replay.ReplayBuild;
        ViewBag.ReplayVersion = replay.ReplayVersion;
        ViewBag.Timestamp = replay.Timestamp;

        ViewBag.APM = CalculateAPM(replay);

        return View();
    }

from sc2replay-csharp.

It seems to be correct, but there may be an issue with player IDs being used in newer replays. I really haven't had much of a chance to test against the latest patch, so I can take a closer look at it. I'd put a breakpoint inside the foreach loop and check that different players are actually there, or that there are multiple groups at all.

I could imagine getting only the first player's APM if there's only 1 player's actions there for some reason... that or the GroupBy isn't working properly.

from sc2replay-csharp.

Closing based on inactivity. If you're still having issues, feel free to open a new issue.

from sc2replay-csharp.