Git Product home page Git Product logo

Comments (2)

ascendedguard avatar ascendedguard commented on July 17, 2024

It seems the team returned by the player details structure is unreliable, I confirmed that this is true in your replay and some other parsers do ignore this field as unreliable. It seems to place to grab this is when parsing the replay.attributes.events, so might require some work to get the right values here.

from sc2replay-csharp.

ascendedguard avatar ascendedguard commented on July 17, 2024

This should be fixed in the latest commit where I redid the ReplayAttributeEvents file, I rely only on this for the correct team numbers and it appears to be correct from my testing. Compile and test with your own replays to verify that it is indeed fixed, and let me know if you have any issues.

from sc2replay-csharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.