xsrf / easyeda-svg-import Goto Github PK

View Code? Open in Web Editor NEW

83.0 6.0 8.0 4.79 MB

Simple SVG Importer for EasyEDA PCB that doesn't convert everything to Comic Sans 😄

JavaScript 99.53% OpenSCAD 0.47%

easyeda svg pcb-design easyeda-extension

easyeda-svg-import's People

Contributors

Stargazers

Watchers

Forkers

mrmx turbobabr mikrodunya easyeda2021 airatnig mankid-leung a1wjun callous4567

easyeda-svg-import's Issues

No path-Tags found (Add more supported tags)

When trying to import this SVG file. Extension shows "No path-Tag found."

This SVG was composed of circule Tags.

<?xml version="1.0" encoding="UTF-8"?>
<svg version="1.1" viewBox="0 0 1000 563" xmlns="http://www.w3.org/2000/svg">
<rect width="1e3" height="563" fill="#fff"/>
<g>
<circle cx="520.78" cy="287.5" r=".0054498"/>
<circle cx="517.32" cy="311.5" r=".0077089"/>
...
...
...
...
<circle cx="-2.2947" cy="-.5" r="1.2656"/>
<circle cx="-2.2947" cy="563.5" r="1.9901"/>
<circle cx="-.56268" cy="566.5" r="1.9901"/>
</g>
</svg>

Can you try to add more Tag support for this extension for it to become more powerful?

Parsing-Error on Numbers with multiple decimal points

SVG is weird... 1.2.3 is correct syntax for 1.2 0.3

https://svg-path-visualizer.netlify.app/#M10%2010%20c%20.36%20-9.09%20%2C7.38%20-16.56%2C%2021.78%20-16.56%207%2C0%2C11.52.9%2C15%2C3.06%2C4.77%2C3%2C7.11%2C7.65%2C7.11%2C13.77v22.95

Import Issues

I don't know if this is an issue or expected behavior, but I thought I would post it anyways.
I am using inkscape 1.0.1

If I create a filled box, circle, hex, and then convert to paths they import as intended.
If I create the same object, but remove the fill and add the outline, they still import as filled.
If I draw a path with a bezier tool, i.e. a curved line, it imports it as filled.
If I draw a horizontal or vertical path, it does not import it at all.

(All items selected in Inkscape and converted to paths before saving).

Thanks!

Use 'pointArr' of solid region for tracks with curves

Just found out that EasyEDA populates the attribute pointArr of a solid region, created by an SVG string, with points that approximate the path. This could also be used for #4 instead of paper.js by creating a temporary solid region... 🤔

Reimport of SVG not showing text location changes

First off thank you for this extension. I was struggling for days trying to get PNG / SVG import to not look like cartoon vomit in EasyEDA with no luck. Any ways not sure if this is a bug or not but I've run into an issue where re-importing the same svg file but with different text locations does not import the updated locations but uses the original ones. It's almost like there is a cached version of the original svg somewhere that it's using. I've checked the svg in multiple viewers and they all show the new locations just fine so I'm at a loss here. This only seems to happen with text objects that are converted to paths.

To explain better:

I created a new file in Inkscape
I added some text and shapes
Converted text and shape objects to paths
Saved it as an svg
Imported using your extension into EasyEDA. Works great. Everything is where it's suppose to be.
Went back into Inkscape and changed the locations of the text.
Saved the svg
Re-imported the svg using your extension but this time the text locations do not change and are in their original location.

This issue seems to be reproduceable. I don't know much about the SVG format but I'm thinking it might have something to do with how Inkscape writes the svg?

EDIT: So looked into it further and it seems for some reason Inkscape does not modify the d= attribute of text but adds in a transform="translate(81.642857,73.327381) attribute instead which I believe your extension does not take into account. Going to look into how I can get Inkscape not to use the transform attribute if possible but maybe also possible to add this into the extension?

Incorrect handling of S/s command

I have an SVG that renders incorrectly. After some investigation, I found that it often uses the "s" command without a preceding cubic Bezier.
According to MDN docs (https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths), "If the S command doesn't follow another S or C command, then the current position of the cursor is used as the first control point.", however this extension currently appears to reflect the last used Bezier's control point regardless of preceding command.

With a small code change to the S and s cases, the image is rendered correctly:

k1x = cx;
k1y = cy;
if (cubicCmds.indexOf(lastLastCmd) >= 0) {
    k1x += cx-k2x;
    k1y += cy-k2y;
}

(cubicCmds is a constant set to ['C', 'c', 'S', 's'], lastLastCmd is copied from lastCmd at the start of the while loop)

Here's a minimal sample SVG that demonstrates the issue, along with before and after screenshots:

I haven't opened this as a PR because you might have a better way of implementing a fix. This is just enough to demonstrate the issue.

Reference SVG file

Do you have any reference SVG file that 100% works with the script? I'm trying to wrap my head around the script you'd developed(thank you very my for the job've done btw) and I can't make it working even with SVG files containing only path based primitives.

It would be really nice to get some working ref examples in the repo.

svg as board cutout border outline(purple line)

it will helpful if their is option available for import svg as board outline for unique shape

Great work by the way
Thanks

SVG from Adobe Illustrator won't import at correct size

Hey!
I'm an absolute babyface PCB/Electronics designer, but I do graphics design. I'm working on getting some panels made using EasyEDA and your SVG Importer. However, I'm using Illustrator instead of Inkscape, and the import-scaling is off. I've setup the document as 72DPI in mm. If I import, i need to set the scaling at around 1.389 (actually 1,389319815999999999...) to get the measurements line up mostly. With 1.389 my 40.30mm PCB is 40.291mm, so that's fine.

While this works, I'm curious where that difference comes from. I'd just prefer my measurements being bang-on :D
Does this have something to do with Illustrator always exporting SVGs at 72DPI (not changeable), while Inkscape uses 96DPI?

Thank you!

<FR> Import multiple layers using label tags

As the manufacturing abilities of the PCB houses keep getting better, it is possible to create very complex artistic PCBs that take advantage of the effects of overlapping layers to get varying colors and tones.
The import at the moment work great on single layer basis. some of these designs require 7 or more separate layers to be imported, and this can be quite tedious to do one at a time, not to mention the alignment.
One possible solution would be to be able to tag the layer for import using the layer name within the svg.
for example
F.Cu
B.Cu
F.SilkS
B.SilkS
F.Mask
B.Mask
Edge.Cuts

This is a demo of how I would image such an SVG world look like to show the layer naming

Uncaught TypeError: svgDocument.matchAll(...)

After selecting a svg file and hit the "Import"-Button , nothing happens.
As you can see in the screenshot below I tried this with different images.

Console Error Output:
Uncaught TypeError: svgDocument.matchAll(...) is not a function or its return value is not iterable

error when loading extension

hello! thanks for this nice feature. unfortunately, i need a bit of help.

trying to load the files within the extension folder but i get a generic error

any idea?

edit: i tried on browser and it works there.
4.4.20.6 is my easyeda version and i'm on OSX 10.12.6

custom pad shape

I'm trying to use svg-import to create a custom pad shape. I import an .svg as a "solid region" and then right-click and "Convert to Pad". It works, but when I add this footprint in a PCB, it's superrr slow and locks up for seconds at a time, making it pretty impossible to work with. Any ideas? Thanks!

Support Scientific number notation

Found an SVG that uses 9.13352234e-15 as coorinates... This is not yet supported.

Use 'createShape' API instead of editing project source

Maybe use createShape API instead of editing project source?

api('createShape',{
	shapeType:'TRACK',
	"jsonCache": {
		gId: "gge"+Math.floor(Math.random() * 9e6),
		layerid: "10",
		pointArr: points
	}
});

jsonCache format is not documented either but should be the same as in the json source...

Not Working?

Disregard!

Extension not appearing in Browser mode

Hello.
I'm using Chrome Version 95.0.4638.69 and Firefox Version 82.0 and after loading the extension, this doesn't appear on the top as used to do.
Unfortunately the extension doesn't Run on my desktop Version.

Do you have the same issue or can i do something to fix it? Thanks.

Unknown commands in SVG

I tried this with a SVG that I have converted from DWG using this page: https://anyconv.com/dwg-to-svg-converter/
I am getting an unknow commands found in SVG. Find the SVG file attached.
m61_pcb_badge_window.zip

Message: N items successfully imported

Andreas,
This is not an issue, but instead a feature request and a minor bug (I think).

It would be great if a message pops up after import that says something like "25 items successfully imported".

Also, it could be just me, but lets say I select a filename "PCB_Graphics.svg".
I import it, and realized I messed up.
I go back and make changes to the file in inkscape and save it.
Now I go back and reload that same file. The changes do not appear. It is like it is not re-loading the new file.
If I resave it in inkscape with a new name, and then import it again, I get the changes.

The new screenshot looks great.

Thanks!

Justin

Paths stopped showing. Log file?

Sorry to post in issues but I have a few paths that were once importing fine but now no longer import. Is there a log file I can reference to check for any import errors?

EDIT: Actually now adding anything new will not show. Something must of gotten messed up in the svg. Any way I can validate the svg? It opens fine in all other programs though.

I found the issue. One of the paths was causing the issue. After deleting it the other paths imported fine. I've included the problem path below.

No path-Tags found

Syntax Error: Unexpected token import.

Tried installing the extension for the OS X desktop client of EasyEDA. It throws "Syntax Error: Unexpected token import" when I try to install the extension in EasyEDA's Extension menu. Throws the error for both versions 1.7 and 1.6 but 1.5 seems to work fine.

Sample SVG that is bad rendered

A three paths svg document with no curves
bitcoin-logo.svg.zip

Convert curves to line segments before importing as track

Tracks (and thus board outlines) only support line segments, no curves. Converting curves to lines with a given resolution would be convenient before import. These may be useful:
https://developer.mozilla.org/en-US/docs/Web/API/SVGGeometryElement/getPointAtLength
https://developer.mozilla.org/en-US/docs/Web/API/SVGGeometryElement/getTotalLength

When importing SVG onto bottom silk later it doesn't flip it

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.