Git Product home page Git Product logo

Comments (8)

xsrf avatar xsrf commented on June 23, 2024 1

Okay, confirmed that. The Desktop Version of EasyEDA ships with Chrome/69.0.3497.128 ... String.matchAll() requires at least Chrome/73 which was released in march 2019. So, for now, the extension will only work in the Browser. I'll have a look if I can find some polyfills to make it also work with that old version.

from easyeda-svg-import.

xsrf avatar xsrf commented on June 23, 2024 1

I found some polyfills and fixed the issue with d926c84 ... Now it should also work in the Desktop Client.

from easyeda-svg-import.

xsrf avatar xsrf commented on June 23, 2024

Okay, the regex won't match any <path ... > tags within the svg. I should add a proper error message for that. Can you provide an example svg?

from easyeda-svg-import.

vlrmprjct avatar vlrmprjct commented on June 23, 2024

Sure.

dd_normalized.zip

from easyeda-svg-import.

xsrf avatar xsrf commented on June 23, 2024

Thank you. The image you provided consists of a lot of <line ... > segments which are not yet supported. But it also contains three <path ... > segments which import fine for me:

2020-11-24 15_24_50-Window

You can however convert the missing lines to paths using the free software Inkscape. Just open the SVG with Inkscape, select everything (CTRL+A) and then convert outlines to paths (Path -> Stroke to Path; CTRL+ALT+C) and save it. After that, the complete image imports fine for me. I've attached the converted image.

2020-11-24 15_34_08-Window

dd_normalized_out2path.zip

from easyeda-svg-import.

vlrmprjct avatar vlrmprjct commented on June 23, 2024

Ok.
Thank you for your response.

But the point is the posted samplefile is a valid SVG and it is created with Inkscape.
So can you please provide some DOES and DONT's for SVGs for a successful import ?

Maybe the readme.md ?

from easyeda-svg-import.

xsrf avatar xsrf commented on June 23, 2024

There is a reference.svg in the root of the project. Also, I cannot reproduce the issue shown in your screenshot even with an empty string loaded as SVG. I guess the browser may be the issue. Are you using the desktop version of EasyEDA? I've actually not tested that yet, I use it with Chrome in the Browser. I've read that the Desktop Version ships with an older Browser version. Maybe that is the issue?

from easyeda-svg-import.

vlrmprjct avatar vlrmprjct commented on June 23, 2024

You are right.
It depends on the browser version.
I testet it in the latest Edge Browser and its working fine with the sample svg above without any changes.

from easyeda-svg-import.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.