Comments (4)
I'm not entirely sure what an implementation of BufMut
would look like for VecDeque
. That being said, both Cursor<T: AsRef<[u8]>>
and Bytes
/ BytesMut
support "draining" without a memmove.
from bytes.
Thanks for the answer.
Using a Cursor<T: AsRef<[u8]>>
would not have the benefit of a ring buffer, which is that once part of the buffer is drained, it can be reused. For example, if you have a sequence like "append 2000 bytes, drain 2000 bytes, append 2000 bytes, drain 2000 bytes...", then a ring buffer can do that without allocating or memmoving, because it just wraps around.
Regarding how an implementation for VecDeque
will look, I am not sure. But generally for a ring buffer, say in it's in a state like this:
# = free
x = used
(region A) (tail) (region B) (head) (region C)
##########################xxxxxxxxxxxxxxxxxxxxxxxx####################
then:
remaining_mut
would return the size of region C + size of region A.bytes_mut
would return region C, or region A if there is no region C.bytes_vec_mut
would return region C, region A.advance_mut
would advance head.
I assume it is not possible to implement this without relying on internal implementation details of VecDeque
, which will never be guaranteed, unlike Vec
. So this issue can probably be closed, and anyone who wants something like that would have to implement their own ring buffer. But thought I'd ask anyway.
from bytes.
Yes, I am familiar w/ the argument for a ring buf. There used to be an implementation of a ring buffer in crate, but it was removed a while ago.
I didn't realize that VecDeque
provided as_slices
which would make it plausible.
If you want to take a shot at implementing Buf
/ BufMut
for VecDeque<u8>
. I think there still may be some missing fns on VecDeque to impl it correctly though.
from bytes.
Closing due to inactivity. Please reopen or create a new issue. if the status changes.
from bytes.
Related Issues (20)
- Feature Request: Default implementations for pinned types HOT 2
- Feature Request: Seekable Buffer ("SeekBuf") and cursor/iterator support HOT 2
- `BufMut` does not include safety invariants in trait documentation HOT 1
- Enable shrinking of allocations
- Contradictory allocation behaviour compared to documentation HOT 9
- Confusing documentation around `Arc<[u8]>` compatibility HOT 1
- Should clone benchmark use use `test::blackbox`? HOT 1
- Explicitly guarantee `Bytes` to be immutable HOT 2
- Expose UTF-8 validated string type HOT 2
- Buf::chunks_vectored() is wrong if chunk() isn't the whole buf HOT 3
- Feature request: fallible version of `BytesMut::unsplit` (i.e. make `BytesMut::try_unsplit` public) HOT 2
- Test for unknown --cfg flags in ci
- Splice for BytesMut HOT 2
- Consider replacing Bytes::make_mut by impl From<Bytes> for BytesMut HOT 5
- Is the conversion from bytes to Vec<u8> O(1) HOT 5
- Feature request: implement `From<Cow<'static, [u8]>>` for `Bytes`
- BytesMut::zeroed doc header improvement HOT 3
- Docs: `Buf::chunk` should have more restrictions. HOT 2
- 1.6.0 yanked? HOT 12
- `impl FromIterator for BytesMut` exposes implementation details HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bytes.