Git Product home page Git Product logo

Comments (2)

dylanplecki avatar dylanplecki commented on September 19, 2024 1

That's a great idea! And a very simple change (already added to the PR), thank you, it was definitely an oversight to not include a Clone impl for BufCursor.

from bytes.

atagen avatar atagen commented on September 19, 2024

Great PR, this is very much something I was looking for in bytes. If for whatever reason this isn't accepted, I would suggest it's worthwhile packaging it as a third-party "add-on" crate.

Regarding using BufCursor for parsing and lookahead - would it be possible to implement Clone for its iterator state?

This would allow passing cheap clones of a BufCursors to sub-functions in a main parsing loop, allowing us to eagerly peek at bytes to return a successful parse or continue on to the next parsing attempt, without disturbing the main cursor's position.

I note this could be achieved at present by checking cursor_position and re-slicing the main buffer into a new cursor each time, but in terms of elegance and transparency I feel like simply cloning the BufCursor would be far superior.

Edit: Okay, I just realised this is what subcursors are for, but it's still kind of suboptimal to deal with n levels of nested BufCursor<BufCursor<...>.

from bytes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.