Comments (2)
That's a great idea! And a very simple change (already added to the PR), thank you, it was definitely an oversight to not include a Clone
impl for BufCursor.
from bytes.
Great PR, this is very much something I was looking for in bytes
. If for whatever reason this isn't accepted, I would suggest it's worthwhile packaging it as a third-party "add-on" crate.
Regarding using BufCursor
for parsing and lookahead - would it be possible to implement Clone
for its iterator state?
This would allow passing cheap clones of a BufCursor
s to sub-functions in a main parsing loop, allowing us to eagerly peek at bytes to return a successful parse or continue on to the next parsing attempt, without disturbing the main cursor's position.
I note this could be achieved at present by checking cursor_position
and re-slicing the main buffer into a new cursor each time, but in terms of elegance and transparency I feel like simply cloning the BufCursor
would be far superior.
Edit: Okay, I just realised this is what subcursors are for, but it's still kind of suboptimal to deal with n levels of nested BufCursor<BufCursor<...>
.
from bytes.
Related Issues (20)
- Enable shrinking of allocations
- Contradictory allocation behaviour compared to documentation HOT 9
- Confusing documentation around `Arc<[u8]>` compatibility HOT 1
- Should clone benchmark use use `test::blackbox`? HOT 1
- Explicitly guarantee `Bytes` to be immutable HOT 2
- Expose UTF-8 validated string type HOT 2
- Buf::chunks_vectored() is wrong if chunk() isn't the whole buf HOT 3
- Feature request: fallible version of `BytesMut::unsplit` (i.e. make `BytesMut::try_unsplit` public) HOT 2
- Test for unknown --cfg flags in ci
- Splice for BytesMut HOT 2
- Consider replacing Bytes::make_mut by impl From<Bytes> for BytesMut HOT 5
- Is the conversion from bytes to Vec<u8> O(1) HOT 5
- Feature request: implement `From<Cow<'static, [u8]>>` for `Bytes`
- BytesMut::zeroed doc header improvement HOT 3
- Docs: `Buf::chunk` should have more restrictions. HOT 2
- 1.6.0 yanked? HOT 12
- `impl FromIterator for BytesMut` exposes implementation details HOT 7
- BytesMut::advance no longer advances cursor HOT 4
- Feature Request? Viewing []Bytes as a single Bytes HOT 6
- `Buf::get_int()` implementation for `Bytes` returns positive number instead of negative when `nbytes` < 8. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bytes.