Feature Request: Default implementations for pinned types about bytes HOT 2 CLOSED

Is this a breaking change? Can people implement Buf for Pin<T> when T is a type they own?

I know that this would normally not be the case, but Pin is #[fundamental] and I'm unsure how that interacts here.

from bytes.

Great point!

After throwing this into the Rust playground (first error is relevant, second is due to my hack reproduction in the playground), I do see that any crate can impl bytes::Buf for any type P due to Pin, and that this change would generate conflicts with any existing impl, so you're right that this is a breaking change (likely negating any positive effect it could have). I think that makes this change dead in the water, and I appreciate the accurate feedback @Darksonn!

If there's any consideration for marking changes for future breaking iterations of the crate, this one would be fairly unremarkable if done early enough, and becomes a useful convenience for async code (though not a requirement as users can manually impl for their own types). See a similar implementation for AsyncRead in futures-io.

from bytes.