Git Product home page Git Product logo

Comments (4)

seanmonstar avatar seanmonstar commented on August 17, 2024

Perhaps some of the other maintainers have different opinions, but my feeling is not to have nightly APIs in the bytes crate. Nightly features tend to have churn, and once it stabilizes, the crate versions that supported it as a nightly feature stop working.

It's fine to experiment, but I wouldn't do so and publish such a fundamental crate as bytes. Once the libstd developers stabilize it, we can adopt it.

from bytes.

dylanplecki avatar dylanplecki commented on August 17, 2024

Absolutely agreed, unstable feature support in public crates does tend to have a code smell to it.

That being said, the allocator_api feature has had some good support for it in public crates. Most notably off the top of my head, the hashbrown crate supports it via a third-party crate that re-exports the unstable allocator interfaces into a stable crate called allocator-api2 (hashbrowns cargo link).

If we want to support the allocator API (i.e. for no_std projects), we can alternatively go the route of using that third-party allocator-api2 crate as hashbrown did (which already supports the ability to optionally drop it to the nightly version).

Link to a similar discussion on hashbrown: rust-lang/hashbrown#417

from bytes.

Darksonn avatar Darksonn commented on August 17, 2024

I'm sorry, but we don't have enough maintainer bandwidth to support something unstable that may require changes in the future.

from bytes.

dylanplecki avatar dylanplecki commented on August 17, 2024

Understandable, and thank you for the continued maintenance.

Since there is a reasonable alternative here to wrap the allocator types in local structs and then re-implement Buf and BufMut, I'll close this issue & related PR, then reopen later pending stabilization of the allocator_api feature.

from bytes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.