Bug: Empty functions are not expanded about minitrace-rust HOT 5 CLOSED

@andylokandy, I'm finding more of these corner cases.... some very subtle inter-plays with rustfmt, clippy macros, etc. Given I'm in the midst of migrating the proc-macro code to the new pipeline structure, I wonder if the least painful path forward won't be to wait until that pipeline refactor lands.

Otherwise I suspect someone faces merge-hell in trying to resolve the pipeline code with these subtle issues fixes.

Thoughts?

from minitrace-rust.

How long will the pipeline refactoring take? Since such subtle cases rarely exist in a practical project (let's say TiKV and RisingLightDB), I think it's not too urgent to fix.

PS: If I didn't get it wrong, the pipeline refactoring could fix those problems, right?

from minitrace-rust.

PS: If I didn't get it wrong, the pipeline refactoring could fix those problems, right?

It might... depends on how subtle the edge cases are. Some others I see now are very subtle.

from minitrace-rust.

How long will the pipeline refactoring take?

Rust's limited integration test support is proving the sticking point. I'm on architecture-attempt #3 to see if I can make it work.

I can say now that edition 2021 looks like a requirement. Not yet sure if that will be able to be contained to the dev/test crates, or if the main crate will need to set that... something to start thinking about.

Weeks not months?

from minitrace-rust.

Voided by PR #127 rejection.

from minitrace-rust.