WASM target support improvements about minitrace-rust HOT 5 CLOSED

You can do: manually flushing -> save spans to be report to static/Arc -> report the spans in a async context

from minitrace-rust.

You can wrap an async function in the sync report function, by simply discarding the Future or storing the Future in a static mutex.

from minitrace-rust.

You can wrap an async function in the sync report function, by simply discarding the Future or storing the Future in a static mutex.

Yeah, but in this case, an async reporter might even be more useful 🤔 I can hook that into the wait_until (https://developers.cloudflare.com/workers/runtime-apis/handlers/fetch/#contextwaituntil) and just await it there without blocking anything.

I can understand the reason for a simple, sync report in minitrace, but in this specific case it feels like a lot of workarounds are needed.

Doing async (runtime) -> sync (Reporter) -> async (actual reporting, HTTP call) feels like a workaround, that can be simplified if report function was async 🤔

from minitrace-rust.

You can do: manually flushing -> save spans to be report to static/Arc -> report the spans in a async context

That's a great idea! I will give it a try :)

from minitrace-rust.

Ok, I managed to make it work!

So basically I created a new special struct that implements Reporter. The report function only collects the span in memory, and I added an async function to do the actual reporting. I can now connect that to the rest of the setup we have.

Thank you for the help @andylokandy , I really appreciate it!

from minitrace-rust.