`Reporter::report` should be `async fn`? 🤔 about minitrace-rust HOT 4 CLOSED

Making report() async will take over control of the runtime from user. I think it'll be opposite to your need.

from minitrace-rust.

If you use LocalCollector, the Reporter will not be enabled. Why you need it to work with threads/blocking stuff?

from minitrace-rust.

Making report() async will take over control of the runtime from user. I think it'll be opposite to your need.

Hmm, actually that's a good point 🤔

If I understand correctly, at the moment, I need to use a blocking mechanism to ship the collected traces in the Reporter. Any idea how can I eventually do something like the following?

let reporter = make_reporter();
let response = run_flow(req);

// This takes the async function and runs it in "background" (NOT in a thread), so it does not block returning the response
context.wait_until(async move {
   // The function here needs to be async, because wasm-bindgen runtime will convert it to JS Promise and will await it
 
   // Calling the reporter like that means that the reporter must be blocking, right?
   // But even if I want to use `reqwest::blocking` here, it's not supported on WASM runtime. 
   // So ideally, I wanted to `.await` this report call. 
   reporter.report(spans)
}); 

response

I guess another way to handle it is to kinda do async(wait_until) -> sync (report) -> async (actual HTTP call to ship the traces)? 🤔 not sure how that would look like 🤔

from minitrace-rust.

If you use LocalCollector, the Reporter will not be enabled. Why do you need it to work with threads/blocking stuff?

I have an abstraction on top of the reporter creation. We are building for 2 targets: WASM (CF Worker) and a binary with actix-web HTTP server. This abstraction handles everything, including plugins like tracing/telemetry.
The only thing left for each runtime is to take care of the tracing lifecycle ( = when to report).

I guess I can wrap the Reporter somehow and have a different mechanism specifically for the WASM runtime, and then ship it as async.

Closing ✅

from minitrace-rust.