I am building a network library, using a large number of Str

Here <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-i

It can be hosted either in this repository <p dir="auto

Closed by <a class="issue-link js-issue-link" data-error-text="Failed to load title" d

`futures::Stream` and `futures::Sink` instrumentation about minitrace-rust HOT 7 CLOSED

iGxnon commented on September 21, 2024 1

`futures::Stream` and `futures::Sink` instrumentation

from minitrace-rust.

Comments (7)

iGxnon commented on September 21, 2024 3

I'd like to help :D

from minitrace-rust.

andylokandy commented on September 21, 2024 2

Yes,this is a good idea!

from minitrace-rust.

andylokandy commented on September 21, 2024 2

Great to have you on board! Let's delve into the details. You can create a new crate named minitrace-futures, and then add SinkInSpan and StreamInSpan. It can be hosted either in this repository or in a new one of your own, depending on your preference.

from minitrace-rust.

iGxnon commented on September 21, 2024 1

Here #202

from minitrace-rust.

iGxnon commented on September 21, 2024

It can be hosted either in this repository

Yes, I want to put it in this repo.

I implemented an initial version that meets the needs of my project while also providing more customization for some other scenarios.
Please give me some advice!

https://github.com/iGxnon/raknet-rs/blob/main/src/utils/minitrace.rs

A usecase in my project:

https://github.com/iGxnon/raknet-rs/blob/73e0da225fd1c6975a52c48497532571a497ac37/src/server/incoming/mod.rs#L38-L85

from minitrace-rust.

andylokandy commented on September 21, 2024

Great job! However, the MakeSpan appears to be overly specific.

Would you consider creating a pull request to include these changes in the repository?

from minitrace-rust.

andylokandy commented on September 21, 2024

Closed by #202

from minitrace-rust.

Recommend Projects