I think the template needs to be tweaked on mobile, see r-lib/pkgdown#312 for more details and beginnings of a fix.

Comment are rather light grey so are probably hard to read for many people

I just clicked on "What does masking mean" and it brings you to the right section, but seems to highlight the one above it. It looks like non-tidytemplate sites don't have this problem.

https://rlang.r-lib.org/reference/topic-data-mask.html#what-does-masking-mean-

i.e. compare to clicking on a TOC section here, which seems to highlight the one you clicked on
https://pkgdown.r-lib.org/articles/customise.html#additional-html-and-files

After I merged #14, I noticed that "part of the tidyverse" has gotten too big.

Top is before, bottom is after the merge.

e.g. The font-size for h3 is 1.6em, but <code> elements get sized to 14px. Matching the h3 font-size looks huge in the code font. My recommended CSS would be:

h3 code {
    font-size: 1em;
}

Currently, I don't think that I can include a link to the tidymodels github page in _pkgdown.yml like this:

template:
  package: tidytemplate
  params:
    part_of: <a href="https://github.com/tidymodels">tidymodels</a>
    # or this
    part_of: [tidymodels](https://github.com/tidymodels)

I don't know a ton about yaml/html interaction, but it seems like you can prevent html escaping by using triple braces? i.e. {{{part_of}}}.
https://github.com/tidyverse/tidytemplate/blob/master/inst/pkgdown/templates/navbar.html#L15

That at least let me do the first part_of option above. If there are other easier solutions that would be nice too. I probably would want to include a link in the footer too.

• Link to dev documentation from navbar
• Package version (only in dev?)
• noindex meta information

• Ensure using latest github action
• Ensure Author includes RStudio as copyright holder and funder
• Update DESCRIPTION
• Ping Hadley to add plausible.io record
• Update template field
• Remove strip_header: true
• Remove algolia search, if used
• Eliminate superseded navbar customisation (home: ~, news instead of at top-level, article re-ordering)
• Remove any tidyverse author info
• Update news structure if needed

This is how it looks

No issue on other page

I suppose this is a template issue as it doesn't happen with pkgdown itself

We have that in site using tidytemplate

Currently, tidytemplate is using ../logo.png to find the logo. I think this might be a mistake, as only logo.png is needed.

The logo is stored at the top level in the gh-pages branch so I dont think there is any need to go up a level.

It works fine for tidyverse packages because the base URL is https://ggplot2.tidyverse.org/ and looking for ../logo.png can't go up any further so it looks to https://ggplot2.tidyverse.org/logo.png.

It does not work for tidymodels packages because the gh-pages URL is https://tidymodels.github.io/yardstick and looking for ..logo.png looks to https://tidymodels.github.io/logo.png when it should be looking for https://tidymodels.github.io/yardstick/logo.png

I have manually changed it to logo.png in the browser and it works for ggplot2 and yardstick.

I can submit a PR if you agree (I will use your code in the README to update scss/ and regenerate tidyverse.css)

Update) Was it supposed to be ./logo.png?

• Use <h1> for package name?
• Use aria-hidden for anchor class?
• Declare language
• Check bootstrap/aria settings for hamburger menu
• Set alt="" for reference icons

• Change font to "Source Sans Pro" + "Source Code Pro"
• Tweak list styling (smaller left margin)
• Tweak heading margins + sizes (smaller font with more whitespace)
• Use dark navbar
• Use borders a little more
• Check primary colour works well with tidy models colour — style non-home page h1 with $primary ?
• Consider footer — not for now
• Authors data for all authors — https://docs.google.com/spreadsheets/d/1Vvz1-e0Cy2n7t8fmCmEDYP_Xm5-hRnWc7oIR7CkppJY/edit#gid=0
• Add a little more margin around headings in navbar dropdown — no need; has border
• Set code width based on font we're using — 73
• Plausible.io

Reference: tidyverse/dplyr#3565 (comment)

Perhaps can be modeled after the pkgdown template: https://github.com/r-lib/pkgdown/blob/fb68cf8f323e86efb5998b93d5c51a70b674e6c3/inst/templates/navbar.html#L27-L33.

Hi,

The paper bootstrap link on Readme.md seems to be generating a 404 error. The site is OK, and I can't find on the site the document that this is likely to refer to.

Compare these two code blocks before and after updating to BS5.

It seems like we have less width for code blocks now (this matters way less for prose). Is there something that should've been set in the Rmd to help with this? Like a width option to prevent tibble from trying to print so many columns?

Before / after switch to BS5

Seems to be a tidy template issue. Compare to pkgdown's article https://pkgdown.r-lib.org/articles/customise.html#theming

Only noticed this the ggplot2 page, since it has enough authors to fill out the text:

I'm happy to do a PR, but wanted to give you first dibs since you're up in there anyhow.

Also (I'm guessing it's for a flexbox reason) but adding margin- or padding-left: 1px; does basically nothing, but padding-left: 2px; see below (which I actually think looks fine, but that's just looking at the ggplot page):

i.e. tidyverse/tidyverse.org#119

Checking if there's anything special we need to add for the subdomains.

I think it would be helpful to add a remotes::install_github("r-lib/usethis") bullet to the beginning of the "Updating" list in the readme to make sure we are using the most recent GHA update

In light of the recent conversation about local images and READMEs, where should logo.png live?

For readxl, I just stowed it under tools/, following what I see in readr, but pkgdown assumes logo.png lives in package's top level directory. To get everything logo-related to work (present in index navbar, creation of favicon), I found I had to also place a copy of this file in top-level directory.

Instead move customisation to a new css file that is loaded last.

So that package pages have previews, too… à la tidyverse/tidyverse.org#123

And can clash with logo colours. Might be better as black.

We haven't noticed this issue on any tidyverse packages (because their names are so short), but when the name of a package is long enough and the screen isn't very wide, you end up moving the "part of tidymodels 0.0.1" to the next line, which can cover up some of the screen, especially on mobile.

Here is what it looks like on a full screen laptop (all good here)

But when you shrink the screen really far you get...

Unfortunately, this is what it defaults to on most mobile screens because they aren't wide enough. Here is my iPhone 6s:

Clearly I just need to choose shorter package names.

alt="" since it's decorative

link to the tidyverse organisation points to haven package. I find it unexpected. Should it rather points to tidyverse.org instead ?

This is the unexpected line in the readme : [tidyverse organisation](http://github.com/tidyverse/haven)

Add logo + link

Per r-lib/pkgdown#599

In certain cases the navbar-brand-container element in the rendered html is coming up empty.
See tidyverse/dbplyr@0724989, where I manually restored the previous navbar brand after rebuild.

I think technically the LINKS header isn't cutoff, but it could really use a little more padding between it and the nav bar

e.g. https://dplyr.tidyverse.org/reference/arrange.html#examples

@dcossyleon do you have any ideas for a better treatment of comments? I want to make sure it's obviously output, not input, but I think the light grey background and dark grey text is a bit hard to read.

• Give <code> a slight radius
• Make header colour a slight mix between fg and primary
• Lighten the sidebar by making headers paler, uppercase, and broadly set

From @dcossyleon

on front page. Is this intended?

Desktop view for tibble

Mobile view

Top section titles are not visible due to navbar masking them: for example in dplyr pkg page both "Overview" in the main section and "Links" in the sidebar are not visible.
Content should be "shifted down" to take into account of the navbar size.

In the screenshot below you can see that the header 2 (h2) containing the section title text "Overview" is masked by the navbar.

As an example of a possible solution (but maybe there is a better way), adding margin-top: 60px to the first div of class row solves the issue.

The issue has been spotted on both Chrome and Firefox.

Here are a couple of examples:

• https://tibble.tidyverse.org/reference/lst.html

• https://dplyr.tidyverse.org/reference/distinct.html

etc.

I've noticed that testthat (which is an r-lib package) has a tidyverse-like GitHub pkgdown Page and I was wondering whether styler should also use this template or whether it is only reserved for (as it says in the README) core tidyverse packages. If the latter is the case, are there any recommendations or / and guidelines on how the GitHub pkgdown Page of r-lib packages should look like? Maybe it would even make sense to adapt this template for r-lib packages so that it resembles the one for core tidyverse packages but the two are still distinguishable?

Reference: r-lib/styler#266

The master branch of this repository will soon be renamed to main, as part of a coordinated change across several GitHub organizations (including, but not limited to: tidyverse, r-lib, tidymodels, and sol-eng). We anticipate this will happen by the end of September 2021.

That will be preceded by a release of the usethis package, which will gain some functionality around detecting and adapting to a renamed default branch. There will also be a blog post at the time of this master --> main change.

The purpose of this issue is to:

• Help us firm up the list of targetted repositories
• Make sure all maintainers are aware of what's coming
• Give us an issue to close when the job is done
• Give us a place to put advice for collaborators re: how to adapt

message id: euphoric_snowdog

https://dplyr.tidyverse.org/dev/index.html

I am getting this error in lubridate pkgdown action.

I have looked at other tidyverse packages and they don't seem to be doing anything specific to install tidytemplate. What am I missing?