Git Product home page Git Product logo

Comments (2)

thunderer avatar thunderer commented on June 16, 2024

Shortcode shouldn't know anything about the context it's being used in, there should be a class called (proposition) ContextAwareShortcode that extends it, provides the same interface (ShortcodeInterface could be helpful for reusable shortcode implementations) and could be typehinted for shortcodes needing that concrete implementation. So far it looks like another BC-breaking idea. 😢

from shortcode.

thunderer avatar thunderer commented on June 16, 2024

Shortcode handler should control processing of shortcode content (possible nested shortcodes), so ContextAwareShortcode should provide ProcessorInterface instance through getProcessor() method. For now shortcode content is processed before shortcode itself and it's done inside processor so outside control of handler. This is a necessary BC-break, I'm not sure when should it happen.

from shortcode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.