Comments (5)
@vmario89 thank you for reporting the issue, I read into the linked Grav issue but I don't see you using shortcodes there? Can you share a minimal text and expected result to reproduce the issue? Thanks!
from shortcode.
Hi,
the shortcode is the collapsible field starting with !> and ending with !@. the content between has Umlauts and does not render, instead fails with the error. The errors throws basically in an class/method of Shortcode which is in user/plugins/shortcode-core/vendor/thunderer/shortcode/src/Parser/RegularParser.php
!> Übersicht anzeigen ...
| Nr | Name |
| --- | --- |
| 17 | Gerhard Werner |
!@
from shortcode.
@vmario89 I can't reproduce the PCRE error on PHP 8.3 and the latest Shortcode version, it would help if you can provide a minimal script for that. Please check RegexBuilderUtility::buildNameRegex()
method, though, and try replacing the regex inside with just \w+
. Parsers restrict the valid shortcode name to [a-zA-Z0-9-_\\*]+
, and that will exclude Übersicht
. If you try the script below it should not apply any changes (shortcode will not be detected because of name restriction), afterwards it will be processed as you expect (result is yes!
). I replied in the Grav repository asking @X-Ryl669 for a small reproduction script as well, as I'm still not sure how Shortcode it setup there and what syntax is used.
<?php
declare(strict_types=1);
namespace X;
use Thunder\Shortcode\HandlerContainer\HandlerContainer;
use Thunder\Shortcode\Parser\RegularParser;
use Thunder\Shortcode\Processor\Processor;
use Thunder\Shortcode\Shortcode\ProcessedShortcode;
require __DIR__.'/vendor/autoload.php';
$handlers = new HandlerContainer();
$handlers->add('Übersicht', fn(ProcessedShortcode $shortcode) => 'yes!');
$processor = new Processor(new RegularParser(), $handlers);
var_dump($processor->process('[Übersicht]'));
from shortcode.
@vmario89 were you able to reproduce the issue in a script you can share? I'm afraid I can't help you without that, everything works fine on my end. Let me know if you have any new information, otherwise I'll close the issue in the near future.
from shortcode.
hey. i am sorry i was not able to find time again yet and i dont know how to do.. i am not a php developer. i am web admin and content maintainer. For me it's hard to think about on all edges and a.t.m. i have no clue how to make a proper test script in the right place :-( i will need to close this then
from shortcode.
Related Issues (20)
- mb_strpos() 3rd parameter is not nullable in PHP 8.1 HOT 2
- [question] Convert content with shortcodes into Json string ? HOT 2
- (question) Also retrieve content outside shortcodes when parsing HOT 3
- Nested shortcodes HOT 4
- unnecessary PREG_OFFSET_CAPTURE usage (?) HOT 2
- RegularParser = Uncaught Error: Maximum function nesting level of '256' reached, aborting! HOT 9
- regular parser throws exception with `param=0` HOT 4
- Method getParameter returns value with quotes HOT 4
- Large file not firing all shortcodes with Regular Parser HOT 4
- Parse error with Vietnamese characters or open and close tag only HOT 6
- I made a new Shortcode library - Inspired by yours HOT 6
- PHP 7.4 issues HOT 3
- mb_strrpos() 3rd parameter deprecated in PHP 7.4 HOT 2
- Custom Short Codes HOT 3
- Multiple options in one add handler HOT 2
- Nested Shortcode for foreach loop HOT 2
- Is it possible to use this without composer? HOT 5
- Is there any built-in method to strip all shortcodes in provided text ? HOT 4
- Issue with Nested shortcodes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shortcode.