Git Product home page Git Product logo

Comments (4)

thunderer avatar thunderer commented on June 19, 2024

Hi @drmzio, you're using WordpressParser which works exactly like WordPress. As noted in the class header, it is meant only as a compatibility layer if you need exactly the same behavior. Did anything change in WordPress that would require an update to this parser?

I recommend you to try the latest library version v0.7.1 with RegularParser. Does it work correctly for your use case?

from shortcode.

thunderer avatar thunderer commented on June 19, 2024

@drmzio By the way, I tested all parsers with the latest version of the library using PHP 7.2, and none of them result in the reported behavior. Could you please tell me what is the output of this code in your environment?

<?php
declare(strict_types=1);
namespace X;

use Thunder\Shortcode\HandlerContainer\HandlerContainer;
use Thunder\Shortcode\Parser\RegexParser;
use Thunder\Shortcode\Parser\RegularParser;
use Thunder\Shortcode\Parser\WordpressParser;
use Thunder\Shortcode\Processor\Processor;
use Thunder\Shortcode\Shortcode\ShortcodeInterface;

require __DIR__.'/vendor/autoload.php';

$handlers = new HandlerContainer();
$handlers->add('hello', function (ShortcodeInterface $s) {
    return sprintf('Hello, %s', $s->getParameter('name'));
});

$input = '[hello name="Daniel"] [hello name=John]';
echo (new Processor(new RegexParser(), $handlers))->process($input)."\n";
echo (new Processor(new RegularParser(), $handlers))->process($input)."\n";
echo (new Processor(new WordpressParser(), $handlers))->process($input)."\n";

from shortcode.

drmzio avatar drmzio commented on June 19, 2024

@thunderer Trying out the code above outputs:

Hello, Daniel Hello, John
Hello, Daniel Hello, John
Hello, Daniel Hello, John

So after further inspection, found out that the Markdown editor was the one escaping quotes. Since this issue isn't related to Shortcode itself, I'm closing this. Thanks for the help!

from shortcode.

thunderer avatar thunderer commented on June 19, 2024

No problem, I'm happy that it works for you, @drmzio!

from shortcode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.