RegularParser = Uncaught Error: Maximum function nesting level of '256' reached, aborting! about shortcode HOT 9 CLOSED

Hi @rhukster, thanks for your report, please look at #72. Can you verify my results using dev-parser-improvements branch?

Your test data runs in ~20ms and uses around 10MiBs of memory in my local environment, Blackfire reports 80ms and ~9MiBs, baseline master ran in 12.5s and used 514MiBs of memory. All tests pass so I'm pretty sure it works correctly, but let me know how does it look on your side.

If everything is fine we have over 100x performance gain on time and memory and RegularParser can be used in all situations without any penalty.

from shortcode.

I can confirm that I've tested the parser-improvements branch and the test case I added as part of #72 now works, an also the actual issue as reported to in getgrav/grav-plugin-shortcode-core#53 and gantry/gantry5#2426 have also been resolved!

I notice now that when there are no actual shortcodes, the regular parser is indeed very fast to process the content, in fact, the fastest of all the 3 parsers.

I've not done any comprehensive performance testing on the parsers for actual shortcode work, but it definitely is faster, and I can find no visible issues with my custom shortcodes page I use for testing.

Nice work! 👍

from shortcode.

@rhukster During the verification phase, I managed to reproduce #70 and added the fix to #72. Could you please verify the results again? I promise I'm not doing anything else with the PR, so it will be merged once I get your approval.

Unfortunately, the fix reduces the performance gains I mentioned above, but we're still well above 10x improvement in both time and memory (850ms and 47MiB on Blackfire, 660ms and 46MiB on local environment, for your test data vs the same baseline). Details are described in the PR if you're interested.

from shortcode.

Please see my comments on the PR itself. Alas, the issue has returned with the latest commit, but does seem to be related to xdebug being on. (was this way with stable release too, I just didn't realize it before).

from shortcode.

Update... latest commits in #72 branch again fixes the issue for me.

from shortcode.

If this PR fixed the issue, may I ask you to close it? I will tag the next version soon, I just need to review the commits since the last version and prepare some release notes.

from shortcode.

Ya all good for me...

from shortcode.

Any word on timing for a new release?

from shortcode.

@rhukster I'm very happy to announce that v0.7.0 was just tagged, you can find the release notes here. While I was writing them I found a lot of small things which could be improved, so #73 will probably become v0.7.1 in the near future.

Thanks a lot for using Shortcode!

from shortcode.