App crash when release RTMP stream about streampack HOT 5 CLOSED

Hi,
FYI, the crash is in the release part of one of the encoder but I don't understand why.
So here comes more questions:

• could you reproduce this crash in the sample app?
• on which devices?
• is there any logs relevant before the crash trace?
• is it random?

from streampack.

hi ThibaultBee,

It always happens on just 1 of my test devices (Galaxy note 5 (Model: SM-N920L) - Android 7). Currently, I'm using RTMP.

Btw, I've found a way to work around this: If I delay about 500ms before calling stream.release(), then it works. : D

Thanks for your reply, and thanks for your lib! 👍

from streampack.

Hi,
I am not really satisfied with this workaround.
I guess the live stream is running, and you called stopStream, then release. Right?
Do you call stopStream and release from the same thread?

The call to MediaCodec release is not sync with the called to MediaCodec stop. This might explains the crash.
I can provide a fix for this but could test it?

from streampack.

Hi ThibaultBee,

I called stop and then release in the same method, and of course, in the same thread. The code runs just fine, but it only crashed on one of my test devices.

I think it may relate to the PreviewView. Because after I delay a few milliseconds to wait for the view to completely leave the composition (My app uses Jetpack Compose, not a normal native app), then calling release won't crash anymore.

from streampack.

Hi ThibaultBee,

I've checked the code again and found that although I call both stop and release in the same method and in the same thread. But actually, the stop() method in the StreamManager which I customized a little bit, was really doing its job on a background thread. After removing the thread, the code runs well on the device without having to delay. So this is my implementation error only, not lib's error. Thanks for your support!

from streampack.