Git Product home page Git Product logo

Comments (8)

kodypeterson avatar kodypeterson commented on July 19, 2024

@ThibaultBee Just wanted to bump this to see if you had any thoughts

from streampack.

ThibaultBee avatar ThibaultBee commented on July 19, 2024

Hi,
Sorry I was off for last couple of weeks.

Why are you trying to mirror the camera?
What surface (preview or stream)?
Is there something wrong with how StreamPack handles the orientation? I have seen a fork where someone try to mirror the video. ๐Ÿค” Is this related with #73?

from streampack.

kodypeterson avatar kodypeterson commented on July 19, 2024

We found this only happens with the front camera. Our end goal is to have the preview surface stay as-is but the stream be mirrored. Reason being is that our use case is more users using the front camera to record themselves do an activity. When watching your self, the way the surface is as of now is what we would expect to see. But, as a viewer of the stream it feels wrong.

Screenshot 2023-07-21 at 2 53 02 PM

This screenshot is a great example. As a streamer, you would expect the screen to not be readable. But, as a viewer you would expect to see it correct as if you were looking at it, in this case mirrored.

from streampack.

ThibaultBee avatar ThibaultBee commented on July 19, 2024

What version are you using?
I am pretty confident it won't fix your issue but I made few changes on the main branch in March which haven't been released yet.
And in the master branch, the issue might be in the OrientationProvider or the CodecSurface of the VideoMediaCodecEncoder.

Finally, IMO it is a bug! ๐Ÿ›

from streampack.

kodypeterson avatar kodypeterson commented on July 19, 2024

@ThibaultBee Thanks for the info - I will likely not be able to dig back into until late next week. Will keep you posted on what I can find.

from streampack.

ThibaultBee avatar ThibaultBee commented on July 19, 2024

Hi,

I started to work on this. See PR #85

Unfortunately, I am not satisfied by the result yet because the during the transition from back to front camera (or front to back), there is a small amount of time were the mirror is applied on the wrong frame.
I would like to mirror only at the exact frame.

from streampack.

ThibaultBee avatar ThibaultBee commented on July 19, 2024

Ok, it seems better.
Could you test #85?

from streampack.

ThibaultBee avatar ThibaultBee commented on July 19, 2024

Released in 2.6.0.
Please reopen the issue if it is not fixed.

from streampack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.